New issue
Advanced search Search tips

Issue 867965 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Mash browser tests are not executing

Project Member Reported by dxie@chromium.org, Jul 26

Issue description

Cc: sky@chromium.org
Cc: est...@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1144640 added a mix of positive and negative filter rules that resulted in no tests running. I have a fix in the CQ.

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23bf5c206d1e94bcaa3412e27477d52fccfb1c60

commit 23bf5c206d1e94bcaa3412e27477d52fccfb1c60
Author: James Cook <jamescook@chromium.org>
Date: Thu Jul 26 20:35:28 2018

Fix mash.browser_tests.filter test filter file so we run tests again

Recently some positive regular expressions were added to the filter.
When combined with the existing negative filters this resulted in
no tests running.

Keep the file a pure blacklist.

TBR=estade@chromium.org

Bug:  867965 
Test: mash_browser_tests on bot
Change-Id: I20b0bc01935fef188c3e21f877a8ad2754dc2250
Reviewed-on: https://chromium-review.googlesource.com/1151765
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578424}
[modify] https://crrev.com/23bf5c206d1e94bcaa3412e27477d52fccfb1c60/testing/buildbot/filters/mash.browser_tests.filter

Status: Fixed (was: Started)
mash_browser_tests are running again:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11181

Status: Verified (was: Fixed)

Sign in to add a comment