New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867955 link

Starred by 2 users
Status: Fixed
Owner:
lethalantidote@chromium.org
Closed: Aug 24
Cc:
lpalmaro@chromium.org
beccahughes@chromium.org
steimel@chromium.org
█ vtsaran@chromium.org
lethalantidote@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Media Controls: offer accessible way to use display cutoff area

Project Member Reported by mlamouri@chromium.org, Jul 26 
In Chrome 69 on Android P, Chrome native controls offers a pinch to zoom into the display cut out area using the new Android P API.

We should offer an accesible (not gesture-related) way to use this feature. Ideally, something that matches other 1P applications on Android.

Comment 1 by aska...@chromium.org, Jul 26

Labels: ReleaseBlock-Stable M-70

Comment 2 by mlamouri@chromium.org, Aug 13

Owner: lethalantidote@chromium.org
Status: Started (was: Available)

Comment 3 by lethalantidote@chromium.org, Aug 23 

Adds button (seen in upper right hand corner)
Screenshot from 2018-08-22 19-12-50.png
108 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f507ed407a12376c0417710f051d3e2c347735ef

commit f507ed407a12376c0417710f051d3e2c347735ef
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Aug 24 23:06:22 2018

Adds button to full screen into the display cutout.

This CL adds an a11y button to allow fullscreening into the display
cutout area in addition the predefined gesture.

Bug:  867955 
Change-Id: I7f1b47b11ac40d9d3ede9181c536d433fdeb03ed
Reviewed-on: https://chromium-review.googlesource.com/1171724
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586037}
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/content/app/strings/content_strings.grd
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/content/child/blink_platform_impl.cc
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/public/platform/web_localized_string.h
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/core/frame/viewport_data.h
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/BUILD.gn
[add] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/elements/media_control_display_cutout_fullscreen_button_element.cc
[add] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/elements/media_control_display_cutout_fullscreen_button_element.h
[add] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/elements/media_control_display_cutout_fullscreen_button_element_test.cc
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[add] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/resources/ic_display_cutout_fullscreen.svg
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
[modify] https://crrev.com/f507ed407a12376c0417710f051d3e2c347735ef/tools/metrics/histograms/histograms.xml

Comment 5 by lethalantidote@chromium.org, Aug 24

Status: Fixed (was: Started)
►

Sign in to add a comment