Whitelist trace events to ease slow-reports analysis |
||
Issue descriptionThe slow-reports traces are collected and sent back for analysis. The traces are anonymized before being sent. The fields needed for analysis needs to be whitelist when needed.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b46813ec05a48a67c32760381d6aa4bb332a47 commit 71b46813ec05a48a67c32760381d6aa4bb332a47 Author: Etienne Bergeron <etienneb@chromium.org> Date: Thu Jul 26 18:54:28 2018 Add GPU events to the whitelist The stripped fields are "line" and "class". see: https://cs.corp.google.com/clankium/src/gpu/ipc/client/gpu_channel_host.cc?l=47 R=oysteine@chromium.org Bug: 867931 Change-Id: Id9374121e57fdad804add77b152f18e53204d8b2 Reviewed-on: https://chromium-review.googlesource.com/1151611 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578387} [modify] https://crrev.com/71b46813ec05a48a67c32760381d6aa4bb332a47/chrome/common/trace_event_args_whitelist.cc
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d30c4f76ff56e988a509fa2dcdb37e54fd632bfa commit d30c4f76ff56e988a509fa2dcdb37e54fd632bfa Author: Etienne Bergeron <etienneb@chromium.org> Date: Fri Aug 03 21:25:20 2018 Add omnibox events to the whitelist R=oysteine@chromium.org Bug: 867931 Change-Id: I257c7b6e6220e9e00eecf3ab14b4cb6e19d55a1b Reviewed-on: https://chromium-review.googlesource.com/1162635 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580654} [modify] https://crrev.com/d30c4f76ff56e988a509fa2dcdb37e54fd632bfa/chrome/common/trace_event_args_whitelist.cc
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c58d619cec56744730d178f97279af2f611d923 commit 9c58d619cec56744730d178f97279af2f611d923 Author: Etienne Bergeron <etienneb@chromium.org> Date: Fri Aug 31 21:42:57 2018 Add task scheduler and cpu_sampler information to slow-reports. This CL is turning on the CPU sampler category. see: https://chromium-review.googlesource.com/c/chromium/src/+/1191745/ It's also turning on the task scheduler info. Which is adding the task_priority to the trace and will ease finding priority inversion. Title TaskTracker::RunTask Category task_scheduler Args task_info {execution_mode: "parallel", task_priority: "USER_BLOCKING"} R=etiennep@chromium.org, oysteine@chromium.org Bug: 867931 Change-Id: I8f6e4772816cc446a25c04ce0cda4b9d45c44232 Reviewed-on: https://chromium-review.googlesource.com/1199567 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#588179} [modify] https://crrev.com/9c58d619cec56744730d178f97279af2f611d923/chrome/common/trace_event_args_whitelist.cc [modify] https://crrev.com/9c58d619cec56744730d178f97279af2f611d923/content/browser/tracing/background_tracing_manager_impl.cc
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2882d19e0bc8ac455f281c498a877b66675ff94a commit 2882d19e0bc8ac455f281c498a877b66675ff94a Author: Etienne Bergeron <etienneb@chromium.org> Date: Wed Sep 12 15:18:38 2018 Fix disabled background tracing categories This CL is fixing: 1) missing comma at the end of a line (missing system_stats) 2) adding prefix disabled by default R=oysteine@chromium.org Bug: 867931 Change-Id: I1fe47c3ba01a738b20e323099c4c1a8ce481eedb Reviewed-on: https://chromium-review.googlesource.com/1220026 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590685} [modify] https://crrev.com/2882d19e0bc8ac455f281c498a877b66675ff94a/content/browser/tracing/background_tracing_manager_impl.cc
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186ba560c7f7c09ccede31b68e573bcbd30b5102 commit 186ba560c7f7c09ccede31b68e573bcbd30b5102 Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Sep 17 21:32:06 2018 Add system_stats events to the whitelist R=oysteine@chromium.org Bug: 867931 Change-Id: Id1c476204b45153e41f0d4bd3d03215d4834104a Reviewed-on: https://chromium-review.googlesource.com/1227650 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591826} [modify] https://crrev.com/186ba560c7f7c09ccede31b68e573bcbd30b5102/chrome/common/trace_event_args_whitelist.cc
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a286374a53874432b5d92fc57a97cfe3bd35fa0b commit a286374a53874432b5d92fc57a97cfe3bd35fa0b Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Oct 01 05:49:17 2018 Add UI category to track fonts loading We want to add the "ui" category to trace fonts loading: void ShapeRunWithFont(const ShapeRunWithFontInput& in, TextRunHarfBuzz::ShapeOutput* out) { TRACE_EVENT0("ui", "RenderTextHarfBuzz::ShapeRunWithFontInternal"); R=oysteine@chromium.org Bug: 867931 Change-Id: I3d3d07516326b3320428d50d164c7fd6a5c3a90a Reviewed-on: https://chromium-review.googlesource.com/1252531 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595386} [modify] https://crrev.com/a286374a53874432b5d92fc57a97cfe3bd35fa0b/content/browser/tracing/background_tracing_manager_impl.cc
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/113acba4154e81809c7c22cbbbb365c8e9ec7ebc commit 113acba4154e81809c7c22cbbbb365c8e9ec7ebc Author: Etienne Bergeron <etienneb@chromium.org> Date: Thu Oct 04 15:10:07 2018 Add shutdown category to slow-reports R=oysteine@chromium.org, sebmarchand@chromium.org Bug: 867931 Change-Id: If49d4168b55b32c46e080018469ff392b8136000 Reviewed-on: https://chromium-review.googlesource.com/c/1259614 Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596670} [modify] https://crrev.com/113acba4154e81809c7c22cbbbb365c8e9ec7ebc/chrome/common/trace_event_args_whitelist.cc [modify] https://crrev.com/113acba4154e81809c7c22cbbbb365c8e9ec7ebc/content/browser/tracing/background_tracing_manager_impl.cc
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe401b4ad665ea72976ff4419f169a0de2b4691 commit 2fe401b4ad665ea72976ff4419f169a0de2b4691 Author: Etienne Bergeron <etienneb@chromium.org> Date: Fri Oct 26 23:14:47 2018 Whitelist sampling profiler events. We recently added error code to sampling profiler. This CL is whitlisting it's args to get the error code. see: https://cs.chromium.org/chromium/src/base/profiler/native_stack_sampler_win.cc?g=0&l=455 if (error_code != NATIVE_STACK_SAMPLER_SUCCESS) { TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cpu_profiler"), "RecordStackFramesFailed", TRACE_EVENT_SCOPE_THREAD, "error_code", NativeStackSamplerErrorToString(error_code)); } R=oysteine@chromium.org Bug: 867931 Change-Id: I1134ccdaaa0586d4102760d8cfc4df2869539f3d Reviewed-on: https://chromium-review.googlesource.com/c/1301835 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603245} [modify] https://crrev.com/2fe401b4ad665ea72976ff4419f169a0de2b4691/chrome/common/trace_event_args_whitelist.cc
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d commit e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Oct 29 22:12:52 2018 Add fallback fonts events to the whitelist. This CL is adding events from the following CL to the whitelist. https://chromium-review.googlesource.com/c/chromium/src/+/1302865 TRACE_EVENT1("ui", "QueryLinkedFontsFromRegistry", "results", logging_str); TRACE_EVENT1("ui", "CachedFontLinkSettings::GetLinkedFonts", "font_name", font_name); R=oysteine@chromium.org Bug: 867931 Change-Id: I89b62a35036a67d1f0f5bf1f490ad476f0586ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1302816 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603651} [modify] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/chrome/common/trace_event_args_whitelist.cc
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ee16e176995f78accc3113cdca6312f41686862 commit 2ee16e176995f78accc3113cdca6312f41686862 Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Nov 26 19:36:17 2018 Add user action to trace events whitelist see: https://cs.chromium.org/chromium/src/base/metrics/user_metrics.cc?l=33 TRACE_EVENT_INSTANT1("ui", "UserEvent", TRACE_EVENT_SCOPE_GLOBAL, "action", action); R=oysteine@chromium.org Bug: 867931 Change-Id: I27b80317c4fccc1bb27958a5c3d0439fd6d760c6 Reviewed-on: https://chromium-review.googlesource.com/c/1350193 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610916} [modify] https://crrev.com/2ee16e176995f78accc3113cdca6312f41686862/chrome/common/trace_event_args_whitelist.cc |
||
►
Sign in to add a comment |
||
Comment 1 by etienneb@chromium.org
, Jul 26