New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867929 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 871733



Sign in to add a comment

Sync stucks in never ending loop when commiting non existed previous typed urls

Reported by j...@opera.com, Jul 26

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36 OPR/54.0.2952.51

Steps to reproduce the problem:
This will be reproducible without PRE_COMMIT_UPDATE_AVOIDANCE(experiments, sync node browser)
1. Change clock behind 5 months
2. Run browser and login to sync
3. open first tab and type elg.no, then type ulv.no(typed_url), do not close tab.
4. Open second tab and type sau.no, then close this tab
5. Go back to previous tab and type different url, leave tab.
6. Close browser
7. Set date ahead, 1 month ahead
8. Run browser, wait for sync
9. Observe sync internals

What is the expected behavior?

What went wrong?
Sync On get updates receives 0 updates in response and it goes in never ending loop.

Did this work before? N/A 

Chrome version: 69.0.3486.0  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
Labels: Needs-Triage-M69
I'm adding more detailed steps to reproduce the problem, this is easier when triggering sync error states.
Steps to reproduce the problem:
This will be reproducible without PRE_COMMIT_UPDATE_AVOIDANCE(experiments, sync node browser).
1. Change clock behind 5 months.
2. Run browser and login to sync.
3. Trigger network error for sync response(that will put synced types in back off state).
4. Open first tab and type elg.no, then type ulv.no(typed_url), do not close tab.
5. Open second tab and type sau.no, then close this tab.
6. Go back to previous tab and type different url, leave tab.
7. Close browser.
8. Set date ahead, 1 month ahead.
9. Run browser, wait for sync(after login we are still in back off state)
10. Disable previously triggered network sync error. 
11. Observe sync internals and wait.
Michał Zajączkowski's patched introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/1151322
I wonder if this explains crbug.com/850893
Cc: mastiz@chromium.org
Labels: Sync-Triaged
Status: Started (was: Unconfirmed)
Thanks for filing the bug. mzajaczkowski@opera.com has started as linked above in comment 3.
Blockedon: 871733
I think we cannot blame the TypedURLSyncBridge for not having the data available (after expiry) and thus causing the infinite loop.

A more appropriate fix (from the point of view of the Chrome Sync team) is being discussed in bug crbug.com/871733, I'll mark this as blocked on the other bug. Please continue in the discussion there.

If you disagree about the dependency, we can also discuss it here.
sync-triage-ping, the other bug came to conclusion how to fix, but this one is still blocked
jkrcal@: can you please provided a quick status update?
Friendly ping for jkrcal@, thanks.
Status: Fixed (was: Started)
This should be fixed thanks to https://chromium-review.googlesource.com/1233676. If you ever encounter it again, please re-open!

Sign in to add a comment