New issue
Advanced search Search tips

Issue 867926 link

Starred by 0 users
Status: Fixed
Owner:
vapier@chromium.org
Closed: Aug 31
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

cros-workon: rip out common.mk support

Project Member Reported by vapier@chromium.org, Jul 26 
since common.mk is no longer as prevalent as it once was (with platform eclass replacing the majority of users), we should rip it out of cros-workon and leave that eclass to only be uprev related.

we still have a handful of packages that use common.mk, so we can add a new eclass ("common.mk.eclass") to hold all the build logic, and update the few projects still using it to inherit that instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f9e20c704911321456ac588dfc4e04e4aaae56e8

commit f9e20c704911321456ac588dfc4e04e4aaae56e8
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Aug 05 03:09:28 2018

common.mk: drop profiling integration

I don't think anyone ever really used this support, and it only
worked for common.mk which has largely been deprecated.  Drop it
to make further cleanups easier.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I4e81f9f69967da99a2669147503c00ee6dd7ae0b
Reviewed-on: https://chromium-review.googlesource.com/1162953
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f9e20c704911321456ac588dfc4e04e4aaae56e8/eclass/cros-workon.eclass
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/50d790abc02ad44698f0bb55db65673ab6ca54cc

commit 50d790abc02ad44698f0bb55db65673ab6ca54cc
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 07 05:11:34 2018

touchpad-tests: simplify ebuild

This ebuild doesn't have any code to compile (it's all python module).
So rip out all the src funcs and update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes

Change-Id: If25d3e3155a10132c448a8c67b43e4390d45e67f
Reviewed-on: https://chromium-review.googlesource.com/1162954
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/50d790abc02ad44698f0bb55db65673ab6ca54cc/x11-drivers/touchpad-tests/touchpad-tests-9999.ebuild
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c38998c18cd12e3264f41bf93dbd3d3743a48f17

commit c38998c18cd12e3264f41bf93dbd3d3743a48f17
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 07 08:50:55 2018

set HOMEPAGE directly

In Gentoo, we have the policy where the HOMEPAGE variable doesn't use
variables in it.  This makes it easier for people reading the file to
visit it directly.  Also, unlike SRC_URI, there's no system in place
to make sure this value stays correct ... if other things change, the
value could break but only if people using indirect tools looked at
it directly.  Switch the few ebuilds using variables over.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I50c66ad7edffc7600cd0eb544ff4b0ea57eba72b
Reviewed-on: https://chromium-review.googlesource.com/1162951
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/media-libs/minigbm/minigbm-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/sys-apps/daisydog/daisydog-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/media-libs/arc-cros-gralloc/arc-cros-gralloc-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/app-benchmarks/punybench/punybench-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/sys-apps/frecon-lite/frecon-lite-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/net-wireless/wpa_supplicant/wpa_supplicant-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/sys-apps/bootcache/bootcache-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/sys-apps/frecon/frecon-9999.ebuild
[modify] https://crrev.com/c38998c18cd12e3264f41bf93dbd3d3743a48f17/sys-apps/mmc-utils/mmc-utils-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b35be500aa06340b858b0342c6ec57b1f1e98a10

commit b35be500aa06340b858b0342c6ec57b1f1e98a10
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 07 08:50:59 2018

cros-workon: drop cros-workon_src_install

This function doesn't do anything useful anymore: the callers using it
either do all the install they need to, or they already call `default`,
or they only call this function which is the same as `default`.  We have
never exported it by default either, so only people explicitly calling
it are impacted.  Drop it to simplify.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I7f200e83d20af3e083c497d3a0403c247678c6b0
Reviewed-on: https://chromium-review.googlesource.com/1163137
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/app-benchmarks/microbenchmarks/microbenchmarks-9999.ebuild
[rename] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/brillo-base/libsparse/libsparse-0.0.1-r4.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/media-libs/minigbm/minigbm-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/chromeos-base/libevdev/libevdev-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/chromeos-base/audiotest/audiotest-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/brillo-base/libsparse/libsparse-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/eclass/cros-workon.eclass
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/chromeos-base/salsa/salsa-9999.ebuild
[rename] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/media-libs/libsync/libsync-0.0.1-r3.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/chromeos-base/avtest_label_detect/avtest_label_detect-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/sys-apps/frecon-lite/frecon-lite-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/sys-apps/bootcache/bootcache-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/media-libs/libsync/libsync-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/sys-apps/frecon/frecon-9999.ebuild
[modify] https://crrev.com/b35be500aa06340b858b0342c6ec57b1f1e98a10/chromeos-base/verity/verity-9999.ebuild
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e518928ce8e65fe510d4280de26f0d016522d4d0

commit e518928ce8e65fe510d4280de26f0d016522d4d0
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 07 21:37:08 2018

cros-workon: drop cw_emake

This wrapper existed to help recover incremental build failures on bots.
The number of common.mk packages has declined significantly as we moved
to platform2/gyp, and our bots have been moving to GCE (so the hostname
check doesn't match) which means that logic doesn't kick in.  Lets drop
this to ease migration to a new common.mk eclass.

If we still run into incremental errors, we can add logic outside the
ebuild that nukes the caches for us.

BUG= chromium:867926 
TEST=precq passes

Change-Id: Iafb71c04c37fc53be61104a9bdb19d8f949b3aed
Reviewed-on: https://chromium-review.googlesource.com/1163138
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/e518928ce8e65fe510d4280de26f0d016522d4d0/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/e518928ce8e65fe510d4280de26f0d016522d4d0/eclass/cros-workon.eclass
[modify] https://crrev.com/e518928ce8e65fe510d4280de26f0d016522d4d0/eclass/cros-kernel2.eclass
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/56d1f1f646aad98b69da7496f806471389392053

commit 56d1f1f646aad98b69da7496f806471389392053
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 08 01:09:00 2018

whining: clean up a bit

- Update to EAPI 6.
- Drop unused cros-constants.
- Set HOMEPAGE to a better location.

BUG= chromium:867926 
TEST=precq passes

Change-Id: Iede4e0091e940230161a6278423d4cc7e497e97f
Reviewed-on: https://chromium-review.googlesource.com/1162950
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/56d1f1f646aad98b69da7496f806471389392053/chromeos-base/whining/whining-9999.ebuild
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5d65e14abe8cadcc471f1f0e14aaffd14dcd7b7c

commit 5d65e14abe8cadcc471f1f0e14aaffd14dcd7b7c
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 08 17:24:57 2018

common.mk: drop valgrind integration

This isn't really used by people, and the dependency doesn't offer
anything useful.  People can still manually set VALGRIND=1.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I0316c63fd5c804233d9152aa412c50df0d73e6ce
Reviewed-on: https://chromium-review.googlesource.com/1162952
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/5d65e14abe8cadcc471f1f0e14aaffd14dcd7b7c/eclass/cros-workon.eclass
[modify] https://crrev.com/5d65e14abe8cadcc471f1f0e14aaffd14dcd7b7c/chromeos-base/verity/verity-9999.ebuild
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/116c428add9f306acfbdfb20adfe6ec6b638eee2

commit 116c428add9f306acfbdfb20adfe6ec6b638eee2
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 09 03:45:59 2018

cros-workon: drop cros-workon_src_test

This function isn't exported by default which means only ebuilds that
call it directly matter.  In that regard, we have only two, and one of
them (rootdev) doesn't actually have a common.mk/tests target.  So we
drop the rootdev user, convert the verity ebuild, and drop the eclass
code entirely.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I9cc1142442a7931a4d27519a02706c8addb9faf1
Reviewed-on: https://chromium-review.googlesource.com/1167476
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/116c428add9f306acfbdfb20adfe6ec6b638eee2/sys-apps/rootdev/rootdev-9999.ebuild
[modify] https://crrev.com/116c428add9f306acfbdfb20adfe6ec6b638eee2/eclass/cros-workon.eclass
[modify] https://crrev.com/116c428add9f306acfbdfb20adfe6ec6b638eee2/chromeos-base/verity/verity-9999.ebuild
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f0db2a9ce00edc3e5613a8e4ba626c226fbffdbe

commit f0db2a9ce00edc3e5613a8e4ba626c226fbffdbe
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 09 09:21:29 2018

salsa: drop unused package

This package hasn't compiled properly in a while and uses things we
want to drop.  Punt it.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I698358a828f780b132f381bd660055027cd9a476
Reviewed-on: https://chromium-review.googlesource.com/1166428
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[delete] https://crrev.com/dad4675f8cfa9ded3bf1a150449e81d6b9583a5d/chromeos-base/salsa/salsa-0.0.1-r2729.ebuild
[delete] https://crrev.com/dad4675f8cfa9ded3bf1a150449e81d6b9583a5d/chromeos-base/salsa/salsa-9999.ebuild
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/052ef3ae4f1990311652087cc62969e56c845cb7

commit 052ef3ae4f1990311652087cc62969e56c845cb7
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Aug 13 21:25:13 2018

cros-common.mk: new eclass for common.mk users

Since common.mk usage is much lower now, start a new eclass to hold
all the related logic.  This way we can rip it out of cros-workon to
make it much simpler.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I6573e63058c266a621b7c421adcd1e823f1220e8
Reviewed-on: https://chromium-review.googlesource.com/1162955
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/052ef3ae4f1990311652087cc62969e56c845cb7/eclass/cros-common.mk.eclass
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/685e5fb54aa1c0cb2312c05e9a217b58ade9d379

commit 685e5fb54aa1c0cb2312c05e9a217b58ade9d379
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 04:58:49 2018

frecon: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ia3c6c5a6b5b59f9f09548e73c30cf8237d6f9bcd
Reviewed-on: https://chromium-review.googlesource.com/1170250
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/685e5fb54aa1c0cb2312c05e9a217b58ade9d379/sys-apps/frecon-lite/frecon-lite-9999.ebuild
[modify] https://crrev.com/685e5fb54aa1c0cb2312c05e9a217b58ade9d379/sys-apps/frecon/frecon-9999.ebuild
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/12cf84c60f091e062ce36d424e347f3ed9a57acc

commit 12cf84c60f091e062ce36d424e347f3ed9a57acc
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 04:58:44 2018

bootcache: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: I5d11fa130852f73e77cfcd69ed195466653ca0c3
Reviewed-on: https://chromium-review.googlesource.com/1170251
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/12cf84c60f091e062ce36d424e347f3ed9a57acc/sys-apps/bootcache/bootcache-9999.ebuild
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fa4049c5307056300790b0b0aa5760ef6867b792

commit fa4049c5307056300790b0b0aa5760ef6867b792
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 04:58:47 2018

verity: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ia809035fba7bbec358a349b2e92511a513725536
Reviewed-on: https://chromium-review.googlesource.com/1170252
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/fa4049c5307056300790b0b0aa5760ef6867b792/chromeos-base/verity/verity-9999.ebuild
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/750c37fe4834d1c7bf091d19aa5705a1201503f1

commit 750c37fe4834d1c7bf091d19aa5705a1201503f1
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 09:13:41 2018

microbenchmarks: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ia9fb604ce79a7d837325ccbc9f1ec9b512811be9
Reviewed-on: https://chromium-review.googlesource.com/1170256
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/750c37fe4834d1c7bf091d19aa5705a1201503f1/app-benchmarks/microbenchmarks/microbenchmarks-9999.ebuild
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a490d5337ecc805f04c40ab8f6d748892477ffb

commit 3a490d5337ecc805f04c40ab8f6d748892477ffb
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 09:13:36 2018

audiotest: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: I1fd6c54b2e6f7489d2d171de4a118fbfc01754a2
Reviewed-on: https://chromium-review.googlesource.com/1170257
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/3a490d5337ecc805f04c40ab8f6d748892477ffb/chromeos-base/audiotest/audiotest-9999.ebuild
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9b9f3ac9b8b6c69de554321dfbec0907e119438d

commit 9b9f3ac9b8b6c69de554321dfbec0907e119438d
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 09:13:33 2018

avtest_label_detect: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ic121c966d55ba14b9893026197c40bbf3dc38b1a
Reviewed-on: https://chromium-review.googlesource.com/1170259
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9b9f3ac9b8b6c69de554321dfbec0907e119438d/chromeos-base/avtest_label_detect/avtest_label_detect-9999.ebuild
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2bd3bc5120135a33b27eaa565b2d459320ebb090

commit 2bd3bc5120135a33b27eaa565b2d459320ebb090
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 12:55:36 2018

mttools: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: I119f5e203a79a11535c4ab208d9cd63ab5a74b75
Reviewed-on: https://chromium-review.googlesource.com/1170253
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/2bd3bc5120135a33b27eaa565b2d459320ebb090/chromeos-base/mttools/mttools-9999.ebuild
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eaf78348c52c38816e4dbe38beb3d02d883eb890

commit eaf78348c52c38816e4dbe38beb3d02d883eb890
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 12:55:28 2018

modp_b64: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ie19ac5c220d5bb11c56dfcd1efbc4b47b5a70199
Reviewed-on: https://chromium-review.googlesource.com/1170255
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/eaf78348c52c38816e4dbe38beb3d02d883eb890/dev-libs/modp_b64/modp_b64-9999.ebuild
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/81d042332a88560fb095914984a8a5d70c199398

commit 81d042332a88560fb095914984a8a5d70c199398
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 14 12:55:32 2018

libevdev: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: Ic570100950f64e2ee0d6e3db7076c5625af2e028
Reviewed-on: https://chromium-review.googlesource.com/1170258
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/81d042332a88560fb095914984a8a5d70c199398/chromeos-base/libevdev/libevdev-9999.ebuild

Comment 20 by la...@chromium.org, Aug 15

Owner: vapier@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8abb2b3bdb7367081725dc052e1be00159f73268

commit 8abb2b3bdb7367081725dc052e1be00159f73268
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 17 18:17:49 2018

minigbm: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes
CQ-DEPEND=CL:1162955

Change-Id: I948748544b5edae7039796c18295b68998691a00
Reviewed-on: https://chromium-review.googlesource.com/1170254
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/8abb2b3bdb7367081725dc052e1be00159f73268/media-libs/minigbm/minigbm-9999.ebuild
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/24ff9466a241afc64af0c0c91c379a10f92e548e

commit 24ff9466a241afc64af0c0c91c379a10f92e548e
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 17 18:17:55 2018

modp_b64: sync the two versions again

This package is blacklisted, but looks like it's fallen out of sync
with the 9999 ebuild.  Bring them back in sync.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I30a027e0877e15959064f219a00005ceb10154ad
Reviewed-on: https://chromium-review.googlesource.com/1176262
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/24ff9466a241afc64af0c0c91c379a10f92e548e/dev-libs/modp_b64/modp_b64-9999.ebuild
[delete] https://crrev.com/ac2bdb84633d96a40e7f8813dc6a06915b5e14f9/dev-libs/modp_b64/modp_b64-0.0.1-r2.ebuild
[rename] https://crrev.com/24ff9466a241afc64af0c0c91c379a10f92e548e/dev-libs/modp_b64/modp_b64-0.0.1-r3.ebuild
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b0ca9d58fc004a411b6d1fdeff92f446fa77eeb6

commit b0ca9d58fc004a411b6d1fdeff92f446fa77eeb6
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Aug 20 01:31:32 2018

mttools: disable tests

This package doesn't provide unittests.  Disable them.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I4c110dfb122527af7ab46c29cda804653cc74d44
Reviewed-on: https://chromium-review.googlesource.com/1179095
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/b0ca9d58fc004a411b6d1fdeff92f446fa77eeb6/chromeos-base/mttools/mttools-9999.ebuild
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3f4ceb2dbba1be7e0ff856f271235aa14c0dbf76

commit 3f4ceb2dbba1be7e0ff856f271235aa14c0dbf76
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 21 04:43:01 2018

minijail: uprev for out-of-tree builds

dd5a884b71f9 fix out-of-tree builds
68a1b3ba4fe2 syscall_filter_unittest: rewrite in C++
05109e461729 syscall_filter_unittest: fix thinko with compile_policy_line
3edca1e85b30 generate_seccomp_policy.py: rewrite in python3 (and style)

BUG= chromium:867926 
TEST=precq passes

Change-Id: I497aa39be25ee4921d49cc8ed9da1bac461e100b
Reviewed-on: https://chromium-review.googlesource.com/1179096
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[rename] https://crrev.com/3f4ceb2dbba1be7e0ff856f271235aa14c0dbf76/chromeos-base/minijail/minijail-1-r19.ebuild
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7e190b10bce62cdcb8d1d74554457017d8acaab8

commit 7e190b10bce62cdcb8d1d74554457017d8acaab8
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 23 20:20:39 2018

minijail: switch to cros-common.mk.eclass

Update to EAPI=6 while we're here.

BUG= chromium:867926 
TEST=precq passes

Change-Id: I727e7ab68e5fcc73ac6b13dcc880d9f5eb24a002
Reviewed-on: https://chromium-review.googlesource.com/1176276
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/7e190b10bce62cdcb8d1d74554457017d8acaab8/chromeos-base/minijail/minijail-9999.ebuild
[rename] https://crrev.com/7e190b10bce62cdcb8d1d74554457017d8acaab8/chromeos-base/minijail/minijail-1-r21.ebuild
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dd0f09192006966e241c090154c27b5d62f3e3d8

commit dd0f09192006966e241c090154c27b5d62f3e3d8
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 24 06:27:50 2018

minigbm: switch to cros-common.mk_src_prepare

BUG= chromium:867926 
TEST=precq passes

Change-Id: Iaa7f02f4eed595d1fb816e091c0fc18711979377
Reviewed-on: https://chromium-review.googlesource.com/1183628
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/dd0f09192006966e241c090154c27b5d62f3e3d8/media-libs/minigbm/minigbm-9999.ebuild
Project Member

Comment 27 by bugdroid1@chromium.org, Aug 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/cd12ac0efdbdcbda95e86cd117dbfa5c521f8151

commit cd12ac0efdbdcbda95e86cd117dbfa5c521f8151
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Aug 25 15:21:06 2018

cros_run_unit_tests: run unittests for common.mk packages

Packages that use common.mk should have unittests.

BUG= chromium:867926 
TEST=precq passes

Change-Id: Id894c71606247b26e43d1f5b7ee1578f697ce50f
Reviewed-on: https://chromium-review.googlesource.com/1162949
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>

[modify] https://crrev.com/cd12ac0efdbdcbda95e86cd117dbfa5c521f8151/lib/portage_util.py
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2d452aa41d85469fa8256574e231ee3f7913e41f

commit 2d452aa41d85469fa8256574e231ee3f7913e41f
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 31 02:33:58 2018

cros-workon: drop common.mk support

We have a cros-common.mk eclass now to hold all this logic.

BUG= chromium:867926 
TEST=precq passes

Change-Id: Ice5418bb19d56646ef95c082739245228f1d2f9d
Reviewed-on: https://chromium-review.googlesource.com/1176125
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/2d452aa41d85469fa8256574e231ee3f7913e41f/eclass/cros-workon.eclass
[modify] https://crrev.com/2d452aa41d85469fa8256574e231ee3f7913e41f/dev-util/turbostat/turbostat-9999.ebuild

Comment 29 by vapier@chromium.org, Aug 31

Status: Fixed (was: Assigned)
should be set now i think
►

Sign in to add a comment