New issue
Advanced search Search tips

Issue 867921 link

Starred by 1 user
Status: Closed
Owner:
etienneb@chromium.org
Closed: Sep 20
Cc:
erikc...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a control population to memlog experiment

Project Member Reported by etienneb@chromium.org, Jul 26 
Memlog is a memory profiling that is using slow-reports to collect reports on high memory usage.

We would like to add a control population to know the average memory usage
used by an average user and being able to take better actions on bad reports based on these metrics. This will help dissociate correct and incorrect memory usage.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e95eafa315bdf27b8f52c2eb64c939e618ac6d0

commit 8e95eafa315bdf27b8f52c2eb64c939e618ac6d0
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Thu Jul 26 16:54:06 2018

Add a sampling trigger to collect memlog reports for a control population

This CL is adding a trigger that randomly collect a sample memlog report.
These reports are used to compare high-memory usage reports with
common memory usage reports.

R=erikchen
BUG= 867921 

Change-Id: I2a05e0dac1184f34ffc32978cbcfc41170a5b665
Reviewed-on: https://chromium-review.googlesource.com/1151406
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578340}
[modify] https://crrev.com/8e95eafa315bdf27b8f52c2eb64c939e618ac6d0/chrome/browser/profiling_host/background_profiling_triggers.cc
[modify] https://crrev.com/8e95eafa315bdf27b8f52c2eb64c939e618ac6d0/chrome/browser/profiling_host/background_profiling_triggers.h
[modify] https://crrev.com/8e95eafa315bdf27b8f52c2eb64c939e618ac6d0/chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36f6d05ebc0e3c40136bdbfa5bcf7064a4a35440

commit 36f6d05ebc0e3c40136bdbfa5bcf7064a4a35440
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Wed Aug 01 20:53:21 2018

Increase the frequency or reports for the control population

We are currently receiving about 300 reports a day.
This CL is moving the frequency by 10x.

R=erikchen

Bug:  867921 
Change-Id: I237e73afa929a0b8358b489dee4fef37f552aeda
Reviewed-on: https://chromium-review.googlesource.com/1159166
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579931}
[modify] https://crrev.com/36f6d05ebc0e3c40136bdbfa5bcf7064a4a35440/chrome/browser/profiling_host/background_profiling_triggers.cc

Comment 3 by etienneb@chromium.org, Sep 20

Status: Closed (was: Untriaged)
►

Sign in to add a comment