This requires the following steps on the client side: 1) Create a new User Consent proto for Chrome Sync 2) Add a new method to the Consent Auditor for recording the new Consent 3) Create a CL for recording the new consent
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/836caeb191580343ffd7d2d65e3a3fed583d69d0 commit 836caeb191580343ffd7d2d65e3a3fed583d69d0 Author: Yue Li <updowndota@chromium.org> Date: Wed Aug 22 18:06:38 2018 Create user consent proto for Assistant activity control Bug: 867919 Test: Local compile Change-Id: Ie5dddbb74cf2d281d152a00231ffdc31b6931dec Reviewed-on: https://chromium-review.googlesource.com/1178989 Reviewed-by: Tim Schumann <tschumann@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#585162} [modify] https://crrev.com/836caeb191580343ffd7d2d65e3a3fed583d69d0/components/sync/protocol/user_consent_specifics.proto [modify] https://crrev.com/836caeb191580343ffd7d2d65e3a3fed583d69d0/components/sync/protocol/user_consent_types.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c1309f3276665c501e62f79a3bfb9244b3dca26 commit 5c1309f3276665c501e62f79a3bfb9244b3dca26 Author: Yue Li <updowndota@chromium.org> Date: Mon Aug 27 00:29:42 2018 Add recording method for Assistant activity control Bug: 867919 Test: Local Compile Change-Id: Icf219704c8640b5112ed9c3b434643757fda4688 Reviewed-on: https://chromium-review.googlesource.com/1183947 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586175} [modify] https://crrev.com/5c1309f3276665c501e62f79a3bfb9244b3dca26/components/consent_auditor/consent_auditor.h [modify] https://crrev.com/5c1309f3276665c501e62f79a3bfb9244b3dca26/components/consent_auditor/consent_auditor_impl.cc [modify] https://crrev.com/5c1309f3276665c501e62f79a3bfb9244b3dca26/components/consent_auditor/consent_auditor_impl.h [modify] https://crrev.com/5c1309f3276665c501e62f79a3bfb9244b3dca26/components/consent_auditor/fake_consent_auditor.cc [modify] https://crrev.com/5c1309f3276665c501e62f79a3bfb9244b3dca26/components/consent_auditor/fake_consent_auditor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07dd5b91d0e88844bfc2a5f121fce15d0dfb1074 commit 07dd5b91d0e88844bfc2a5f121fce15d0dfb1074 Author: Yue Li <updowndota@chromium.org> Date: Mon Aug 27 17:17:17 2018 Recording assistant activity control consent Bug: 867919 Test: Local Compile Change-Id: I4500ed2ceb047fb5557717b038f4a057ec251ce6 Reviewed-on: https://chromium-review.googlesource.com/1186125 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586294} [modify] https://crrev.com/07dd5b91d0e88844bfc2a5f121fce15d0dfb1074/chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_handler.cc [modify] https://crrev.com/07dd5b91d0e88844bfc2a5f121fce15d0dfb1074/chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_handler.h [modify] https://crrev.com/07dd5b91d0e88844bfc2a5f121fce15d0dfb1074/chromeos/services/assistant/public/proto/consent_flow_ui.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4336e2136befa094e0df1cf4d066e717959fa4ff commit 4336e2136befa094e0df1cf4d066e717959fa4ff Author: Markus Heintz <markusheintz@chromium.org> Date: Tue Aug 28 12:22:08 2018 [User Consent] Implement RecordAssistantActivityControlConsent Bug: 867919 Change-Id: I39368fd24237987d59d6ce6b8102fd67b3856e1f Reviewed-on: https://chromium-review.googlesource.com/1190762 Reviewed-by: Yue Li <updowndota@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586663} [modify] https://crrev.com/4336e2136befa094e0df1cf4d066e717959fa4ff/components/consent_auditor/consent_auditor_impl.cc [modify] https://crrev.com/4336e2136befa094e0df1cf4d066e717959fa4ff/components/consent_auditor/consent_auditor_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/073886e887fe132e4862264f8cac847ec9473e28 commit 073886e887fe132e4862264f8cac847ec9473e28 Author: Markus Heintz <markusheintz@chromium.org> Date: Wed Aug 29 16:34:18 2018 [User Consent] Add fallback for recording ASSISTANT_ACTIVITY_CONSENT via UserEventSpecifics. In case of the very unlikely event of disabling user consent recording via the separate sync data type UserConsentSpecifics, this fallback logic kicks in and records the consent via the event logger. Bug: 867919 Change-Id: Ie10fc2ba374f47a914796e175c4e34f9921a976d Reviewed-on: https://chromium-review.googlesource.com/1193892 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587149} [modify] https://crrev.com/073886e887fe132e4862264f8cac847ec9473e28/components/consent_auditor/consent_auditor_impl.cc [modify] https://crrev.com/073886e887fe132e4862264f8cac847ec9473e28/components/consent_auditor/consent_auditor_impl_unittest.cc [modify] https://crrev.com/073886e887fe132e4862264f8cac847ec9473e28/components/sync/protocol/proto_enum_conversions.cc [modify] https://crrev.com/073886e887fe132e4862264f8cac847ec9473e28/components/sync/protocol/user_event_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60647a0f381929889b9d9bf1d0909ffd3e598fcb commit 60647a0f381929889b9d9bf1d0909ffd3e598fcb Author: Markus Heintz <markusheintz@chromium.org> Date: Thu Aug 30 13:48:15 2018 [User Consent] Feature enums in UserConsentSpecifcis and UserEventSpecifics.Consent must match. Bug: 867919 Change-Id: I3804c09877d8b1f44fadcd062a3930e76a4684c4 Reviewed-on: https://chromium-review.googlesource.com/1196445 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#587554} [modify] https://crrev.com/60647a0f381929889b9d9bf1d0909ffd3e598fcb/components/sync/protocol/proto_enum_conversions.cc [modify] https://crrev.com/60647a0f381929889b9d9bf1d0909ffd3e598fcb/components/sync/protocol/user_consent_specifics.proto
Comment 1 by mastiz@chromium.org
, Jul 28