Broken DOM autocomplete suggestions
Reported by
da...@aplexpress.co.uk,
Jul 26
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36 Steps to reproduce the problem: 1. Create a basic HTML form with a type="tel" input 2. Use multiple values in the autocomplete attribute (allowed as per https://goo.gl/6KgkJg) <input type="tel" name="phone-number" autocomplete="shipping tel tel-national"> What is the expected behavior? I shouldn't get any DOM suggestions for this field as all recommended attributes are set. What went wrong? I get multiple lines in Dev Tools suggesting I use attribute values already present: 09:02:26.589 [DOM] Input elements should have autocomplete attributes (suggested: autocomplete='tel', confirm at https://goo.gl/6KgkJg) 09:02:26.589 [DOM] Input elements should have autocomplete attributes (suggested: autocomplete='tel-national', confirm at https://goo.gl/6KgkJg) <input type="tel" name="phone-number" autocomplete="shipping tel tel-national"> Did this work before? N/A Chrome version: 68.0.3440.75 Channel: stable OS Version: Ubuntu 18.04 Flash Version:
,
Aug 1
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa43848a4701d74a4ff4e742c6a4c7c6e61dab21 commit fa43848a4701d74a4ff4e742c6a4c7c6e61dab21 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Aug 01 19:26:52 2018 [Autofill] Turn off DOM Autocomplete suggestions by default. Bug: 867893 , 853940 , 869912 Change-Id: Ia9a2729682dd8cbbc662562ab4ce9f79bfc1fbd2 Reviewed-on: https://chromium-review.googlesource.com/1158720 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579897} [modify] https://crrev.com/fa43848a4701d74a4ff4e742c6a4c7c6e61dab21/components/autofill/core/common/autofill_features.cc
,
Aug 2
Tested this issue on Ubuntu 17.10 on reported chrome version 68.0.3440.75. 1. Launched reported Chrome 2. Created html file with given code We have not seen any DOM autocomplete suggestions @Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process. Could you please help in verifying this issue. Thanks!
,
Aug 2
Turning them off hasn't fixed the bug (or bug 853940 for that matter). If I turn them on to see suggestions (which I will do if I can), it will still incorrectly tell me to use attributes already present. The fix needs to be to do a further check and see if the attribute is in use before suggesting it.
,
Aug 2
Looking at //src/components/autofill/content/renderer/form_cache.cc starting line 528 it seems it was coded to handle multiple strings. However on line 552, we check to see if the wrong string is present, which is the right thing to do, but we should also check at this point that the correct string isn't already present.
,
Aug 2
Thanks David, you may stop investigating, it will be turned off in the next day or so :) I'll mark this bug as fixed when it is so.
,
Aug 2
Will it possible to turn it on in DevTools settings or this a permanent off switch? It's a useful feature to have!
,
Aug 2
Good suggestion, for now I was intending on having the warnings show for other Chrome channels, such as Canary, Dev, and Beta.
,
Aug 2
They'll now be suppressed after a few Chrome restarts. You can also have them by starting Chrome with a command-line flag: --enable-features=AutofillShowAutocompleteConsoleWarnings
,
Aug 2
OK I'll run with that flag when you've switched it off. Shame I'm not skilled enough to fix it myself! |
||||
►
Sign in to add a comment |
||||
Comment 1 by caseq@google.com
, Jul 26Owner: ma...@chromium.org
Status: Assigned (was: Unconfirmed)