New issue
Advanced search Search tips

Issue 867874 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 868037
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Menu highlight needs to be clipped to menu bounds

Reported by db...@etouch.net, Jul 26

Issue description

Chrome Version :70.0.3503.0 Revision 133bb5b6c29cddabaa398c300034afb3c701de2a-refs/branch-heads/3503@{#1}(64 bit)
Mac(10.13.1,10.14,10.12.6) OS

Pre-Condiiton: Enable 'Use Views browser windows instead of Cocoa' flag from chrome://flags and relaunch the browser.

What steps will reproduce the problem?
(1) Launch chrome, open New incognito window and bookmark page into 'Other bookmarks' 
(2) Click on 'Other bookmarks' and hover mouse on link.
(3) Observe highlight on it.

Actual: Focus highlight goes out of the border of bookmarked link box.

Expected: Focus highlight should seen properly.

This is a regression issue, broken in 'M69', below is bisect info:

Good Build:69.0.3489.0(Revision: 574446)
Bad Build:69.0.3491.0(Revision:575129)

You are probably looking for a change made after 574749 (known good), but no later than 574750 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/3bb8e0e2f98fa7ac912b0051d452d86a0d1bb27f..29b678961513d03f4065f12061cabac15698b381

Suspect: https://chromium.googlesource.com/chromium/src/+/29b678961513d03f4065f12061cabac15698b381

@ftirelo: Could you please check whether this is caused with respect to your change, if not please help to reassigning it to the right owner.

Note: Above issue is not seen on Win(7,8,8.1,10) and Linux(14.04 LTS) OS.
 
Actual_Highlight.mov
3.1 MB View Download
Expected_Highlight.mov
1.5 MB View Download
Actual_Screenshot.png
313 KB View Download
Components: -Blink UI
Cc: ellyjo...@chromium.org
Labels: -Pri-1 Pri-2
Summary: Menu highlight needs to be clipped to menu bounds (was: Regression: [Incognito] Focus highlight goes out of the border of bookmarked link box.)
This is a consequence of the corner radius being larger than the top/bottom padding. An easy fix would be to increase the top/bottom padding specifically to 8pt. A more difficult fix would be to clip the highlight to the menu's rounded rect.

ftirelo@: thoughts? :)
Looks like a dupe of  issue 868037 .
Mergedinto: 868037
Status: Duplicate (was: Assigned)
mehmet@: marking as duplicate, since it's being handled there.

Sign in to add a comment