New issue
Advanced search Search tips

Issue 867838 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 1
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Tool-tip of 'Print destinations' is incorrect in Print preview overlay.

Reported by sanyam.g...@etouch.net, Jul 26 
Chrome Version: 70.0.3503.0 (Official Build) Revision 133bb5b6c29cddabaa398c300034afb3c701de2a-refs/branch-heads/3503@{#1}(64-bit)

OS: Windows(7,8,8.1,10) and Linux(14.04 LTS)

Pre-condition:
1.Enable 'Enable new Print Preview UI' from chrome://flags.

Steps to reproduce:
(1) Launch Chrome, open NTP and give print command using 'Ctrl+P' to open Print Preview overlay.
(2) Click on 'Change' button to open 'Select a destination' overlay.
(3) Observe the Tool-tip of 'Print destinations'.

Actual Result: Tool-tip of 'Print destinations' is incorrect.
Expected Result: Tool-tip of 'Print destinations' should be correct.

This is a regression issue, broken in 'M-70', and below is bisect-info:
Good Build:70.0.3501.0(Revision:578159)
Bad Build: 70.0.3503.0(Revision:577394)

Narrow Bisect URL: 

https://chromium.googlesource.com/chromium/src/+log/aba6c716b4a3daf5c5d47017c16265c15981081f..fc566d1c1a2d8da82ccce610b153f3b54524eab4

Suspecting: r577742? 

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Actual tool-tip of 'Print destinations' is misplaced and is seen below the list of destinations.
2. This issue is not seen on Mac(10.12.6, 10.13.1, 10.13.6, 10.14)OS.

Kindly review the attached screen-cast for reference.

Thank you!
Actual_Result.mp4
870 KB View Download
Expected_Result.mp4
703 KB View Download

Comment 1 by rbpotter@chromium.org, Jul 26

Status: Started (was: Assigned)
At least on Linux, these headings don't seem to have tooltips in the existing Print Preview UI, and they do not seem to have any benefit since the text is identical to the heading text. Will just remove them.

Comment 2 by rbpotter@chromium.org, Jul 26

Labels: -Pri-1 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dd87b6e0ec1b53f1fc463be97fa09074a084de6

commit 5dd87b6e0ec1b53f1fc463be97fa09074a084de6
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Jul 28 03:35:52 2018

Print Preview: Remove destination list tooltips

These tooltips do not exist in the original UI and were accidentally
added to the new one. Since the text is identical to the displayed
title, there is no reason for them to exist. Remove them by
renaming the "title" property to "listName", as the title attribute
is used to create tooltips.

Bug:  867838 
Change-Id: Ie2e6dfa5bd38f9a7c2aea80b2742a46abd866aa1
Reviewed-on: https://chromium-review.googlesource.com/1152451
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578911}
[modify] https://crrev.com/5dd87b6e0ec1b53f1fc463be97fa09074a084de6/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/5dd87b6e0ec1b53f1fc463be97fa09074a084de6/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/5dd87b6e0ec1b53f1fc463be97fa09074a084de6/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/5dd87b6e0ec1b53f1fc463be97fa09074a084de6/chrome/test/data/webui/print_preview/destination_list_test.js

Comment 4 by rbpotter@chromium.org, Aug 1

Status: Fixed (was: Started)
Tooltips should be removed by CL in comment 3.
►

Sign in to add a comment