Non-Regression: Ubertray traces are seen on Shut down button when language is changed from English to Arabic |
|||||
Issue descriptionChrome Version:69.0.3497.14/10895.5.0 dev channel Daisy,Celes,Kip OS: Chrome OS What steps will reproduce the problem? (1)Recover Build >> In OOBE,'Choose your language & Keyboard' page ,select any language which starts from R.H.S(Ex:Arabic) (2)Observe near Shut Down button while changing the language Actual: Ubertray traces are seen on Shut down button when language is changed to Arabic Expected: No such delay should be seen when language is changed to Arabic This is a Non-Regression issue seen from M-62 Note:Issue is not seen in Linux,Windows OS Attached the sreencast for reference..
,
Jul 27
,
Aug 7
,
Nov 8
I think I could reproduce this but slightly different pattern. Let us know if this is different from the original report. 1. Recover Build >> In OOBE, click the button with globe icon to enter 'Choose your language & Keyboard' mode. 2. Change language to Arabic. 3. Change language to some other RTL language. I could not have found the exact set of languages that can reproduce this. I confirmed with Simplified Chinese, Traditional Chinese and Serbian, but not on English-US and Japanese. The shut-down button moves to the right place (left, for RTL language), but the system tray doesn't. As a result, those two appears overlapped on the left side, and the right side is empty.
,
Nov 8
,
Nov 9
This happens when switching between RTL and LTR languages, but only when the both has only one keyboard each. (i.e. no keyboard type icon shown like [US] in the systray). Simplified Chinese (LTR) and Arabic (RTL) is an example of such combination. English (United States) will not match this condition as it has multiple keyboards. This has been happening because the system tray is not refreshed after language change. We didn't have such logic as OOBE is the only place where language can be changed without signing out. (usually, language change requires session reset.) I'll add a new Mojo channel to notify locale change to ash. FYI There is class named LocaleNotificationController, but it's a different thing. It's used for showing confirmation before actually changing locale.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d commit 440e2d2ecd18d8d0aaeb4f3ac02989fec977640d Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Dec 05 09:16:31 2018 Unified: Refresh system tray upon locale change during OOBE. In OOBE, the UI locale can be updated by the "Choose language and keyboard" menu, and it's instantly reflected to the UI without rebooting the session. The unified system tray is also shown in OOBE. Layout of the shelf needs to be updated based on if the language is left-to-right or right-to-left. Test: Manually verified as noted in the bug. Bug: 867832 Change-Id: I38de2baa21a6333b28c04c1d5b157910042ca3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1332971 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613911} [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/BUILD.gn [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/manifest.json [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/mojo_interface_factory.cc [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/public/interfaces/locale.mojom [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/shell.cc [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/shell.h [delete] https://crrev.com/2dfd136766503e2a72dc2b7d2e5b339c8068275d/ash/system/locale/locale_notification_controller.h [rename] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/system/locale/locale_update_controller.cc [add] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/ash/system/locale/locale_update_controller.h [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/chrome/browser/chromeos/locale_change_guard.cc [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/chrome/browser/chromeos/locale_change_guard.h [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/chrome/browser/chromeos/login/screens/welcome_screen.cc [modify] https://crrev.com/440e2d2ecd18d8d0aaeb4f3ac02989fec977640d/chrome/browser/chromeos/login/screens/welcome_screen.h
,
Dec 6
M72 has already been branched. The fix will be shipped on M73. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rkalavakuntla@chromium.org
, Jul 263.1 MB
3.1 MB View Download
1.4 MB
1.4 MB View Download
7.5 MB
7.5 MB View Download