New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867820 link

Starred by 2 users
Status: Untriaged
Owner:
sergeyu@chromium.org
Cc:
mbonadei@chromium.org
█ phoglund@chromium.org
█ titovartem@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove chromium dependencies on WebRTC internals

Project Member Reported by titovartem@chromium.org, Jul 26 
Currently chromium have dependencies on WebRTC private targets, even on third party libraries. It is required to stop using them and switch on chromium owned third party libraries or chromium source itself.

WebRTC third party dependency //third_party/webrtc/rtc_base/third_party/sigslot:sigslot
(Header third_party/webrtc/rtc_base/third_party/sigslot/sigslot.h)
Chromium files, where it is used:
content/renderer/media/webrtc/stun_field_trial.h
content/renderer/p2p/empty_network_manager.h
content/renderer/p2p/filtering_network_manager.h
jingle/glue/chrome_async_socket_unittest.cc
jingle/notifier/base/weak_xmpp_client_unittest.cc
jingle/notifier/base/xmpp_connection.h
remoting/protocol/channel_socket_adapter.h
remoting/protocol/ice_transport_channel.h
third_party/libjingle_xmpp/task_runner/task.h
third_party/libjingle_xmpp/task_runner/taskrunner.h
third_party/libjingle_xmpp/xmpp/asyncsocket.h
third_party/libjingle_xmpp/xmpp/jingleinfotask.h
third_party/libjingle_xmpp/xmpp/prexmppauth.h
third_party/libjingle_xmpp/xmpp/xmppclient.cc
third_party/libjingle_xmpp/xmpp/xmppclient.h
third_party/libjingle_xmpp/xmpp/xmpptask.h

WebRTC third party dependency //third_party/webrtc/rtc_base/third_party/base64:base64
(Header third_party/webrtc/rtc_base/third_party/base64/base64.h)
Chromium files, where it is used:
third_party/libjingle_xmpp/xmpp/saslmechanism.cc
third_party/libjingle_xmpp/xmpp/xmpplogintask.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68b05be470693b5a6a0dc552f2e9b78cb8659d00

commit 68b05be470693b5a6a0dc552f2e9b78cb8659d00
Author: Artem Titov <titovartem@chromium.org>
Date: Tue Jul 31 08:06:14 2018

Switch from temporary sigslot.h to the right one.

This CL switch only imported header file to unblock WebRTC refactoring
to move sigslot target to proper location. But it is required that
all usages of sigslot will be eliminated from chromium code base. Here
is a ticket to track this effort: https://crbug.com/867820

Bug: 867820,  webrtc:8366 
Change-Id: I431a178048886833b8bbd8508ce5a3937997f5ab
Reviewed-on: https://chromium-review.googlesource.com/1150537
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Artem Titov <titovartem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579340}
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/content/renderer/BUILD.gn
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/content/renderer/media/webrtc/stun_field_trial.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/content/renderer/p2p/empty_network_manager.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/content/renderer/p2p/filtering_network_manager.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/jingle/glue/chrome_async_socket_unittest.cc
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/jingle/notifier/base/weak_xmpp_client_unittest.cc
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/jingle/notifier/base/xmpp_connection.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/remoting/protocol/channel_socket_adapter.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/remoting/protocol/ice_transport_channel.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/task_runner/task.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/task_runner/taskrunner.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/asyncsocket.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/jingleinfotask.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/prexmppauth.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/xmppclient.cc
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/xmppclient.h
[modify] https://crrev.com/68b05be470693b5a6a0dc552f2e9b78cb8659d00/third_party/libjingle_xmpp/xmpp/xmpptask.h

Comment 2 by titovartem@chromium.org, Aug 22

Cc: titovartem@chromium.org

Comment 3 by titovartem@webrtc.org, Aug 23

Blocking: -webrtc:8366
►

Sign in to add a comment