New issue
Advanced search Search tips

Issue 867809 link

Starred by 1 user
Status: Fixed
Owner:
perezju@chromium.org
Closed: Jul 26
Cc:
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix pylint warnings in devil

Project Member Reported by perezju@chromium.org, Jul 26 
With the new pylint roll, we now have a bunch of new PRESUBMIT errors that need fixing in devil.

See e.g.:
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/12733/steps/presubmit/logs/stdio
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/721613b08607357b57c046131eed4441e190eb56

commit 721613b08607357b57c046131eed4441e190eb56
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jul 26 15:26:25 2018

[devil] Fix PRESUBMIT errors in devil

Bug:  chromium:867809 
Change-Id: I6c34b64b147706a6a9322e20b7bd1624ee519875
Reviewed-on: https://chromium-review.googlesource.com/1151118
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/utils/cmd_helper.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/flag_changer.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/sdk/shared_prefs.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/utils/find_usb_devices.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/perf/thermal_throttle.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/device_errors.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/tools/script_common_test.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/tools/device_monitor.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/perf/perf_control.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/tools/device_recovery.py
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/pylintrc
[modify] https://crrev.com/721613b08607357b57c046131eed4441e190eb56/devil/devil/android/forwarder.py

Comment 2 by perezju@chromium.org, Jul 26

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/896c0fa88f26ba9a7baa583e995c6ce8ad127fa1

commit 896c0fa88f26ba9a7baa583e995c6ce8ad127fa1
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jul 26 18:49:32 2018

Roll src/third_party/catapult f07f60ef0baa..721613b08607 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/f07f60ef0baa..721613b08607


git log f07f60ef0baa..721613b08607 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 perezju@chromium.org [devil] Fix PRESUBMIT errors in devil
2018-07-26 anthonyalridge@google.com Graph Data API change
2018-07-26 perezju@chromium.org Fix PRESUBMIT errors in catapult/experimental


Created with:
  gclient setdep -r src/third_party/catapult@721613b08607

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:867809 ,chromium:866423, chromium:867844 
TBR=sullivan@chromium.org

Change-Id: I5f2e7a10c7729efd3daacdf25ca68340f2ee5ed1
Reviewed-on: https://chromium-review.googlesource.com/1151547
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578384}
[modify] https://crrev.com/896c0fa88f26ba9a7baa583e995c6ce8ad127fa1/DEPS
►

Sign in to add a comment