Rename audio service sandboxing feature flag |
|||||
Issue descriptionFlag was renamed in https://crrev.com/c/1148449 on master branch. Logging a separate bug to merge the change into M69, so we can use the same flag name in beta and canary/dev audio service experiments.
,
Jul 26
,
Jul 26
Feature flag was renamed on master, requesting merge to use the same flag name in beta and canary/dev audio service experiments.
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week LAST M69 Dev release before Beta promotion. Thank you.
,
Jul 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05de225decca34cdba8917dfd3a2c3dec63b2eb9 commit 05de225decca34cdba8917dfd3a2c3dec63b2eb9 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Sat Jul 28 08:49:21 2018 Rename audio service sandboxing flag. This flag will be reused to enable sandbox on Mac in an experiment, hence dropping the "Windows" from flag name. Bug: 867808 Change-Id: Idc46f244b29425b60c42bf1b7288023206cffc19 Reviewed-on: https://chromium-review.googlesource.com/1148449 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577804}(cherry picked from commit 755abc7f25c5628a5f72729b9ae0de2765164774) Reviewed-on: https://chromium-review.googlesource.com/1154327 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#186} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/05de225decca34cdba8917dfd3a2c3dec63b2eb9/content/browser/webrtc/webrtc_audio_browsertest.cc [modify] https://crrev.com/05de225decca34cdba8917dfd3a2c3dec63b2eb9/content/browser/webrtc/webrtc_getusermedia_browsertest.cc [modify] https://crrev.com/05de225decca34cdba8917dfd3a2c3dec63b2eb9/services/service_manager/sandbox/features.cc [modify] https://crrev.com/05de225decca34cdba8917dfd3a2c3dec63b2eb9/services/service_manager/sandbox/features.h [modify] https://crrev.com/05de225decca34cdba8917dfd3a2c3dec63b2eb9/services/service_manager/sandbox/sandbox_type.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by marinaciocea@chromium.org
, Jul 26Summary: Rename audio service sandboxing feature flag (was: Merge into M69 renamed audio service sandboxing feature flag)