New issue
Advanced search Search tips

Issue 867799 link

Starred by 2 users
Status: Started
Owner:
johnylin@chromium.org
Cc:
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 863321


Sign in to add a comment

Change ARC++ VEA IPC to use Config struct on Initialize (with h264_output_level parameter)

Project Member Reported by johnylin@chromium.org, Jul 26 
This change could fix b/110811755

As  crbug.com/863321 , VideoEncodeAccelerator::Initialize() will change to use Config struct with all required encoding parameters inside, including |h264_output_level| for specifying h264 output level.

Change ARC++ VEA IPC Initialize function to align to VDA interface.

Comment 1 by johnylin@chromium.org, Jul 26

Blockedon: 863321
Labels: OS-Chrome
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd43a7ef75cd5a5943af7b055155f3fee0b88f26

commit fd43a7ef75cd5a5943af7b055155f3fee0b88f26
Author: Pin-chih Lin <johnylin@chromium.org>
Date: Wed Aug 29 13:45:47 2018

components/arc: use Config struct for Initialize of ArcVEA Mojo IPC

VideoEncodeAccelerator::Initialize() now use Config struct to pass
initial parameters. Change ArcVEA Mojo IPC to align with this new API.

BUG=867799
TEST=build and deploy chrome on Eve, verify ARC++ encoder is good

Change-Id: I0a4b1f80d2d5c6b8baa0fa734129ef1cc79b55ab
Reviewed-on: https://chromium-review.googlesource.com/1172463
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587097}
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/common/video_encode_accelerator.mojom
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/common/video_encode_accelerator.typemap
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/common/video_encode_accelerator_struct_traits.cc
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/common/video_encode_accelerator_struct_traits.h
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.cc
[modify] https://crrev.com/fd43a7ef75cd5a5943af7b055155f3fee0b88f26/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c10a3f1711dcb71cadba85a925b41a285f7428

commit a0c10a3f1711dcb71cadba85a925b41a285f7428
Author: Pin-chih Lin <johnylin@chromium.org>
Date: Wed Oct 17 12:33:20 2018

components/arc: remove InitializeDeprecated of ArcVEA Mojo

InitializeDeprecated should be removed after ToT of ARC-P and ARC-N have
upreved to use new Initialize API.

BUG=867799
TEST=build and deploy chrome on Grunt

Change-Id: I6d2215b9fe735fbb4e1dd4aa179a55187ec908db
Reviewed-on: https://chromium-review.googlesource.com/c/1282518
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600358}
[modify] https://crrev.com/a0c10a3f1711dcb71cadba85a925b41a285f7428/components/arc/common/video_encode_accelerator.mojom
[modify] https://crrev.com/a0c10a3f1711dcb71cadba85a925b41a285f7428/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.cc
[modify] https://crrev.com/a0c10a3f1711dcb71cadba85a925b41a285f7428/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.h
►

Sign in to add a comment