Web page is cut off at docked keyboard shadow |
|||||
Issue descriptionChrome Version: 70.0.3502.0 OS: ChromeOS Eve What steps will reproduce the problem? (1) Launch the new UI docked virtual keyboard. What is the expected result? The shadows are semi-transparent; you should be able to see parts of the window behind the shadow. What happens instead? The shadows are opaque.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60b9c2fffb00aabd81da961035c22e381c64659e commit 60b9c2fffb00aabd81da961035c22e381c64659e Author: Darren Shen <shend@chromium.org> Date: Mon Jul 30 05:21:31 2018 [VK] Draw shadows for docked keyboard. In a previous patch, we removed shadows for both docked and floating keyboard so that IME can draw them. Unfortunately, this means that KeyboardController no longer knows which area of the keyboard is the shadow and which is the actual UI, which breaks things like overscrolling. A fix would be to make IME indicate what the actual occluded bounds are through setOccludedBounds. Unfortunately, setOccludedBounds has several problems (e.g. what happens when occluded bounds and visual bounds go out of sync, e.g. when the screen is rotating). This requires some additional thought. So in the meantime, we just draw shadows only for docked mode. This will at least unblock the new UI while we find a permanent solution. Bug: 867775 Change-Id: Iebd8f5edfeac5643fe837b672bf65dab5bfcdb4d Reviewed-on: https://chromium-review.googlesource.com/1152328 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578979} [modify] https://crrev.com/60b9c2fffb00aabd81da961035c22e381c64659e/chrome/browser/ui/ash/chrome_keyboard_ui.cc [modify] https://crrev.com/60b9c2fffb00aabd81da961035c22e381c64659e/chrome/browser/ui/ash/chrome_keyboard_ui_unittest.cc [modify] https://crrev.com/60b9c2fffb00aabd81da961035c22e381c64659e/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
,
Jul 30
Requesting M69 merge for c#2. Thanks!
,
Jul 31
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9b5cfaae0e9cc00906e21e764f1863b7462301f commit d9b5cfaae0e9cc00906e21e764f1863b7462301f Author: Darren Shen <shend@chromium.org> Date: Tue Jul 31 06:51:22 2018 [VK] Draw shadows for docked keyboard. In a previous patch, we removed shadows for both docked and floating keyboard so that IME can draw them. Unfortunately, this means that KeyboardController no longer knows which area of the keyboard is the shadow and which is the actual UI, which breaks things like overscrolling. A fix would be to make IME indicate what the actual occluded bounds are through setOccludedBounds. Unfortunately, setOccludedBounds has several problems (e.g. what happens when occluded bounds and visual bounds go out of sync, e.g. when the screen is rotating). This requires some additional thought. So in the meantime, we just draw shadows only for docked mode. This will at least unblock the new UI while we find a permanent solution. Bug: 867775 Change-Id: Iebd8f5edfeac5643fe837b672bf65dab5bfcdb4d Reviewed-on: https://chromium-review.googlesource.com/1152328 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578979}(cherry picked from commit 60b9c2fffb00aabd81da961035c22e381c64659e) Reviewed-on: https://chromium-review.googlesource.com/1156204 Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#261} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/d9b5cfaae0e9cc00906e21e764f1863b7462301f/chrome/browser/ui/ash/chrome_keyboard_ui.cc [modify] https://crrev.com/d9b5cfaae0e9cc00906e21e764f1863b7462301f/chrome/browser/ui/ash/chrome_keyboard_ui_unittest.cc [modify] https://crrev.com/d9b5cfaae0e9cc00906e21e764f1863b7462301f/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
,
Jul 31
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 26