Highlights not working in supersize ui |
||
Issue descriptionAdded in https://chromium-review.googlesource.com/c/chromium/src/+/1148795. Ran: tools/binary_size/supersize start_server report.ndjson "Show only generated files" checkbox causes nothing to load (I see an empty / dir). The radios don't seem to do anything for me.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800 commit 17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800 Author: Tiger Oakes <tigero@google.com> Date: Thu Jul 26 18:41:58 2018 SuperSize: Fix highlights not updating for containers When adjusting the radio buttons, hightlights only update for symbols and not for containers. This is now fixed. Additionally, the dynamic inputs (byteunit and highlight) previously did not disappear from the URL when set back to the default value. This is now fixed. The UI code has been cleaned up a little and more comments have been added. Bug: 867760 Change-Id: I6671b28939d73a32222a1b5f6dcaf18da8783e68 Reviewed-on: https://chromium-review.googlesource.com/1151622 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#578383} [modify] https://crrev.com/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800/tools/binary_size/libsupersize/static/index.html [modify] https://crrev.com/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800/tools/binary_size/libsupersize/static/main.css [modify] https://crrev.com/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800/tools/binary_size/libsupersize/static/state.js [modify] https://crrev.com/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800/tools/binary_size/libsupersize/static/tree-ui.js
,
Sep 13
|
||
►
Sign in to add a comment |
||
Comment 1 by tigero@google.com
, Jul 26