Add zip/unzip integration tests |
||||||||||||
Issue descriptionIssue 836412 broke the Files app zip/unzip feature due to a change in Content Security Policy ( issue 865197 , issue 864256). The new CSP policy wasn't added to the Files app zip/unzip extension manifest. Fix was on https://chromium-review.googlesource.com/1147893 We should add integration tests for zip/unzip to prevent such regressions.
,
Jul 26
,
Jul 26
https://chromium-review.googlesource.com/c/chromium/src/+/1150008 to add unzip tests. Note the test do not use CheckifNoerrors() at the end of each test, because the Action model throws an error. For example in the zipFileOpenDownloads test: filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/dmboannefpncccogfdikhmhpmdnddgoe%3A~%252FDownloads%252Farchive%252Ezip%3Auser/ main_scripts.js:12283 Error: console.error at console.error (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js:12282:17) at ActionsModel.<anonymous> (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js:20210:25) Arguments ["Failed to fetch custom actions because of: Failed to fetch actions.", callee: (...), Symbol(Symbol.iterator): ƒ]0: "Failed to fetch custom actions because of: Failed to fetch actions."callee: (...)length: 1Symbol(Symbol.iterator): ƒ values()get callee: ƒ ()set callee: ƒ ()__proto__: constructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()get __proto__: ƒ __proto__()set __proto__: ƒ __proto__() main_scripts.js:12285 Failed to fetch custom actions because of: Failed to fetch actions. (anonymous) @ main_scripts.js:12285 (anonymous) @ main_scripts.js:20210 Some error in the ActionsModel code: seems new, seems Drive-related (not using Drive directly in the ), something due the new team-drives code.
,
Jul 26
,
Jul 26
More yaks per square meter, e.g., why in test zipFileOpenDownloads, does the dmboannefpncccogfdikhmhpmdnddgoe: 'ZipArchiver' issue _so many_ warnings: ==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from ZipFiles/FilesAppBrowserTest [ RUN ] ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads [232212:232212:0726/121135.363172:WARNING:user_policy_manager_factory_chromeos.cc(209)] No policy loaded for known non-enterprise user [232212:232212:0726/121135.506855:ERROR:content_gpu_interface_provider.cc(83)] Not implemented reached in virtual void ash::ContentGpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [232212:232212:0726/121135.576835:INFO:file_manager_browsertest_base.cc(1053)] FileManagerBrowserTest::StartTest zipFileOpenDownloads [232212:232212:0726/121136.166788:INFO:CONSOLE(5611)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5611) [232212:232212:0726/121136.200599:INFO:CONSOLE(4896)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4896) [232212:232212:0726/121136.201574:INFO:CONSOLE(5613)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5613) [232212:232212:0726/121136.201929:INFO:CONSOLE(5623)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5623) [232212:232212:0726/121136.203428:INFO:CONSOLE(6048)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6048) [232212:232212:0726/121136.203561:INFO:CONSOLE(1172)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1172) [232212:232212:0726/121136.204073:INFO:CONSOLE(5623)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5623) [232212:232212:0726/121136.204191:INFO:CONSOLE(6048)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6048) [1,3135152768:02:11:36.275205] Native Client module will be loaded at base address 0x0000266600000000 [232212:232212:0726/121136.284752:INFO:CONSOLE(6096)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6096) [232212:232212:0726/121136.291767:INFO:CONSOLE(5627)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5627) [232212:232212:0726/121136.298329:INFO:CONSOLE(6096)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6096) [232212:232212:0726/121136.299567:INFO:CONSOLE(5627)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5627) [232212:232212:0726/121136.299679:INFO:CONSOLE(5631)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5631) [232212:232212:0726/121136.312497:INFO:CONSOLE(4893)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4893) [232212:232212:0726/121136.657948:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [1,3135152768:02:11:38.032109] Native Client module will be loaded at base address 0x00006e5a00000000 [1,3135152768:02:11:38.126425] Native Client module will be loaded at base address 0x000025dc00000000 [232212:232212:0726/121138.186895:INFO:CONSOLE(6048)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6048) [232212:232212:0726/121138.193839:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.201094:INFO:CONSOLE(6096)] "File system obtained: provided:dmboannefpncccogfdikhmhpmdnddgoe:~%2FDownloads%2Farchive%2Ezip:user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6096) [232212:232212:0726/121138.217529:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.217635:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.217732:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.217822:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.250558:INFO:CONSOLE(31521)] "File watchers not supported for: filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/dmboannefpncccogfdikhmhpmdnddgoe%3A~%252FDownloads%252Farchive%252Ezip%3Auser/", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (31521) [232212:232212:0726/121138.273224:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.273341:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.273434:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.273531:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.321116:INFO:CONSOLE(12283)] "Failed to fetch custom actions because of: Failed to fetch actions.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (12283) [232212:232212:0726/121138.321338:INFO:CONSOLE(0)] "IsDirectory specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.321532:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.322001:INFO:CONSOLE(0)] "IsDirectory specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.322174:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.329190:INFO:CONSOLE(0)] "IsDirectory specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.329668:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.329766:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.329856:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.330123:INFO:CONSOLE(0)] "IsDirectory specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.330219:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.330308:INFO:CONSOLE(0)] "Size specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.330410:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.373451:INFO:CONSOLE(0)] "[SUCCESS] [zipFileOpenDownloads]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) [232212:232212:0726/121138.396246:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.396434:INFO:CONSOLE(0)] "Last modification time specified, but not requested.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.397897:INFO:CONSOLE(0)] "Unchecked runtime.lastError: The browser is shutting down.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [232212:232212:0726/121138.467571:ERROR:provided_file_system.cc(543)] Failed to create an abort request. [232212:232225:0726/121138.523430:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [232212:232212:0726/121138.528156:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [232212:232212:0726/121138.528190:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [232212:232533:0726/121138.531088:WARNING:internal_linux.cc(64)] Failed to read /proc/232248/stat [ OK ] ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads (4664 ms) [----------] 1 test from ZipFiles/FilesAppBrowserTest (4664 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (4664 ms total) [ PASSED ] 1 test. [1/1] ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads (5506 ms) SUCCESS: all tests passed.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/605757eee32c2873576eec4c69ebade18a4dde8f commit 605757eee32c2873576eec4c69ebade18a4dde8f Author: Noel Gordon <noel@chromium.org> Date: Thu Jul 26 03:26:34 2018 Add FilesApp integration tests for unzipping a zip archive Add tests cases for unzipping a zip archive from Downloads, Drive, and a removable volume (USB). Test: browser_tests --gtest_filter="ZipFiles/FilesApp*" Bug: 864256, 865197 , 867738 Change-Id: Iea2d2a8537798d7eb4eab7370862fe27a4054a7e Reviewed-on: https://chromium-review.googlesource.com/1150008 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578182} [modify] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [add] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/ui/file_manager/integration_tests/file_manager/zip_files.js [modify] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/ui/file_manager/integration_tests/file_manager_test_manifest.json
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eddae27eae74dce26655d2e3639943013dd66bd3 commit eddae27eae74dce26655d2e3639943013dd66bd3 Author: Noel Gordon <noel@chromium.org> Date: Thu Jul 26 04:29:42 2018 Rename zip archive file content rows helper Call it getUnzippedFileRowEntries for less confusion. Bug: 867738 Change-Id: I0e38e8c41ec0cfc599aaa24b369738ffea3c2f0a Reviewed-on: https://chromium-review.googlesource.com/1150953 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578197} [modify] https://crrev.com/eddae27eae74dce26655d2e3639943013dd66bd3/ui/file_manager/integration_tests/file_manager/zip_files.js
,
Jul 26
#6 is failing with persistent TIMEOUT on the DEBUG bots [1]. The NaCl module doing the unzipping is crashing. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939952778072119936/+/steps/browser_tests/0/logs/ZipFiles__x2f_FilesAppBrowserTest.Test__x2f_zipFileOpenDownloads/0 ... [26985:26985:0726/022918.480892:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [26985:26985:0726/022921.028234:INFO:CONSOLE(156)] "at /file_manager/background.js:373:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [26985:26985:0726/022924.099324:INFO:CONSOLE(156)] "at /file_manager/background.js:373:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [26985:26985:0726/022928.109989:INFO:CONSOLE(156)] "at StepsRunner.<anonymous> (/file_manager/zip_files.js:45:18): waitForFiles: expected: [["image.png","272 bytes","PNG image","Sep 2, 2013, 10:01 PM"],["text.txt","51 bytes","Plain text","Sep 2, 2013, 10:01 PM"]] actual [["archive.zip","533 bytes","Zip archive","Jan 1, 2014, 1:00 AM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [1,1945618368:09:29:34.485273] Native Client module will be loaded at base address 0x0000229600000000 [1,1945618368:09:29:34.743631] Native Client module will be loaded at base address 0x0000768d00000000 assertion "var_dict.Get(request::key::kOperation).is_int()" failed: file "../../chrome/browser/resources/chromeos/zip_archiver/cpp/module.cc", line 168, function: virtual void NaclArchiveInstance::HandleMessage(const pp::Var &) ** abort() called ** Signal 4 from untrusted code: pc=768d00168560 [26985:27531:0726/022935.059031:ERROR:nacl_process_host.cc(262)] NaCl process exited with status 64512 (0xfc00) [26985:26985:0726/022935.066598:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [26985:26985:0726/022937.241620:INFO:CONSOLE(156)] "at StepsRunner.<anonymous> (/file_manager/zip_files.js:45:18): waitForFiles: expected: [["image.png","272 bytes","PNG image","Sep 2, 2013, 10:01 PM"],["text.txt","51 bytes","Plain text","Sep 2, 2013, 10:01 PM"]] actual [["archive.zip","533 bytes","Zip archive","Jan 1, 2014, 1:00 AM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) Test is waiting for the NaCl module to complete the unzip, but it has crashed and so the test => TIMEOUT.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4810077ba30e7f6d975ca5d061f56ce35ad65787 commit 4810077ba30e7f6d975ca5d061f56ce35ad65787 Author: Noel Gordon <noel@chromium.org> Date: Thu Jul 26 11:16:12 2018 Disable FilesAppBrowserTest zipFileOpen tests in DEBUG NaCl module is crashing in DEBUG in the zipFileOpen* cases: causes the DEBUG bots to TIMEOUT waiting for the unzipped file results. Disable these tests in DEBUG. Tbr: hbos@ Bug: 867738 , 867842 Change-Id: If2717bcd2f427c7e8ff0bd5a532f0a9405bfc31d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1151176 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578259} [modify] https://crrev.com/4810077ba30e7f6d975ca5d061f56ce35ad65787/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Jul 26
,
Jul 26
Expected that MSAN/ASAN might be affected and TIMEOUT like DEBUG, but the first MSAN results are in, and they were green [1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ZipFiles%2FFilesApp*
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc0182d589d4a8d6c3f07611aa002e388a8d4fca commit cc0182d589d4a8d6c3f07611aa002e388a8d4fca Author: Noel Gordon <noel@chromium.org> Date: Thu Jul 26 14:31:37 2018 Add FilesApp integration tests for zipping a file Add tests cases for zipping a file: test Downloads, Drive, and USB, to get the "create-a-zip-file" integration test ball rolling. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*zipCreate*" Bug: 864256, 865197 , 867738 Change-Id: I28c2da7bd5662ef944659c11529d963cf81d48ed Reviewed-on: https://chromium-review.googlesource.com/1151068 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578295} [modify] https://crrev.com/cc0182d589d4a8d6c3f07611aa002e388a8d4fca/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/cc0182d589d4a8d6c3f07611aa002e388a8d4fca/ui/file_manager/integration_tests/file_manager/zip_files.js
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03be2ef72a968150b5388ac937ea68444718a5fc commit 03be2ef72a968150b5388ac937ea68444718a5fc Author: Noel Gordon <noel@chromium.org> Date: Fri Jul 27 01:45:20 2018 Rename the unzipped file row helper Call it getUnzippedFileListRowEntries, ie. add the FileList part to be consistent with zip helper getZipSelectionFileListRowEntries. Minor: more consistency, use !!result everywhere. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*" Bug: 867738 Change-Id: I448442ac959e44da162fca0c6c15f230fa4bc1dd Reviewed-on: https://chromium-review.googlesource.com/1151587 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578513} [modify] https://crrev.com/03be2ef72a968150b5388ac937ea68444718a5fc/ui/file_manager/integration_tests/file_manager/zip_files.js
,
Aug 9
Issue 454910 has been merged into this issue.
,
Aug 9
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db7657b8d3d775d3c9ce4dc338d03b0a16e808bc commit db7657b8d3d775d3c9ce4dc338d03b0a16e808bc Author: Noel Gordon <noel@chromium.org> Date: Fri Aug 10 12:17:31 2018 Add a missing ZipArchiver operation define: READ_METADATA READ_METADATA was defined in the NaCL C++ but wasn't defined in the JS code. It is a requirement of the ZipArchiver design that the operation values are defined, and have the same values, in the C++ and JS code. This is likely causing crashes in the field: it certainly caused CHECK stop crashes in DEBUG C++ NaCL code in integration test (ZipArchiver's unit_tests did not exhibit the bug at all). Define READ_METADATA in the JS, add protective code to check operation validity (make it throw, if not) when constructing pack messages in JS that will be sent to the NaCL module C++ code. Re-enable the zip integration tests that were disabled due to this bug in issue 867738 . (Those tests discovered bug 867842 ). Test: browser_test --gtest-filter="Zip*FilesApp*" No-try: true Bug: 867842 , 867738 Change-Id: Ide44e60a47d9e87322115dc66017e8e0313b2162 Reviewed-on: https://chromium-review.googlesource.com/1169485 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582123} [modify] https://crrev.com/db7657b8d3d775d3c9ce4dc338d03b0a16e808bc/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/db7657b8d3d775d3c9ce4dc338d03b0a16e808bc/chrome/browser/resources/chromeos/zip_archiver/cpp/request.h [modify] https://crrev.com/db7657b8d3d775d3c9ce4dc338d03b0a16e808bc/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/db7657b8d3d775d3c9ce4dc338d03b0a16e808bc/chrome/browser/resources/chromeos/zip_archiver/js/request.js
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a7bd1a4ecd1b98c80ad212230d0612dec8d685b commit 4a7bd1a4ecd1b98c80ad212230d0612dec8d685b Author: Noel Gordon <noel@chromium.org> Date: Thu Aug 16 12:37:34 2018 Disable zipfile tests on ASAN due to NaCl compilation failures The zip unpacker NaCl plugin compilation fails too often on ASAN; that causes persistent time-out flakes. Disable these tests on ASAN only. Bug: 867738 Change-Id: Ib370b0896afe13a3ebbd33b3d93db2d9f39b39b5 Reviewed-on: https://chromium-review.googlesource.com/1177401 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583617} [modify] https://crrev.com/4a7bd1a4ecd1b98c80ad212230d0612dec8d685b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Aug 16
Zip/Unzip integration tests active and green in RELEASE/DEBUG/MSAN. ASAN disabled due to #19, and no active work on NaCl these days. With issue 785501 fixed, WASM is now an option for chrome extensions so we could swap out NaCl and use WASM instead. Another idea is do it via Fuse, DriveFS-like, with the added advantage we could use Chrome's third_party/zlib, which is SIMD optimized on Intel and ARM see issue 764085.
,
Aug 21
Test results link for reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ZipFiles%2FFilesApps*
,
Oct 2
,
Nov 7
The chrome-os ASAN bots now have longer test time-out limits, much larger than the 60 sec limit that caused #18 #19. We should re-enable the zip file tests on ASAN, and see if they can no run to completion ... fingers-crossed.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6eee6f0840c8ea34ac01b70f082a506a351d702 commit b6eee6f0840c8ea34ac01b70f082a506a351d702 Author: Noel Gordon <noel@chromium.org> Date: Wed Nov 07 03:20:00 2018 Re-enable FilesApp zip file integration tests on ASAN The Chrome OS ASAN bots now have longer test time-outs limits and maybe enough to run the zip file tests to completion. Let's see. Bug: 867738 Change-Id: Ibda0a13ccb13095d14504c19d48d619cee5d5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1321653 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605944} [modify] https://crrev.com/b6eee6f0840c8ea34ac01b70f082a506a351d702/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Nov 12
ASAN intermittently runs to completion. The ASAN bot fails to compile the .pexe sometimes, causing a timeout-flake.
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d934948431f2afd0e40130c91f9ca4cb37bb6941 commit d934948431f2afd0e40130c91f9ca4cb37bb6941 Author: Noel Gordon <noel@chromium.org> Date: Mon Nov 12 06:09:50 2018 Revert "Re-enable FilesApp zip file integration tests on ASAN" This reverts commit b6eee6f0840c8ea34ac01b70f082a506a351d702. Reason for revert: still not enough reliability in the NaCl compiler on the ASAN bots. Original change's description: > Re-enable FilesApp zip file integration tests on ASAN > > The Chrome OS ASAN bots now have longer test time-outs limits and maybe > enough to run the zip file tests to completion. Let's see. > > Bug: 867738 > Change-Id: Ibda0a13ccb13095d14504c19d48d619cee5d5cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/1321653 > Reviewed-by: Anand Mistry <amistry@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605944} TBR=noel@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867738 Change-Id: Ie0cf1a09d880692ca1ba1c2ce3ab3645405e05e3 Reviewed-on: https://chromium-review.googlesource.com/c/1329818 Reviewed-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607155} [modify] https://crrev.com/d934948431f2afd0e40130c91f9ca4cb37bb6941/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Nov 12
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by noel@chromium.org
, Jul 26