New issue
Advanced search Search tips

Issue 867732 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Jul 27
Cc:
rsesek@chromium.org
phanindra.mandapaka@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Mac app menu 'Settings' hotkey listed as "⌘ Comma" not "⌘,"

Project Member Reported by tapted@chromium.org, Jul 26 
Chrome Version       : 70.0.3502.0

What steps will reproduce the problem?
1. Open app/hotdog menu and observe

What is the expected result?

⌘,


What happens instead of that?

⌘Comma


(in m68 this has no hotkey string +bisect to see where it appeared, but maybe rsesek knows)
Screen Shot 2018-07-26 at 11.20.08.png
48.8 KB View Download

Comment 1 by phanindra.mandapaka@chromium.org, Jul 26

Cc: phanindra.mandapaka@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Bisect hasbisect-per-revision RegressedIn-70 Triaged-ET ReleaseBlock-Stable Target-70 M-70 FoundIn-70 Pri-1 Type-Bug-Regression
Owner: rsesek@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce issue on reported chrome version 70.0.3502.0 & on latest chrome 70.0.3503.0 using Mac 10.13.5. Hence providing bisect information below.

Bisect Info:
================
Good build: 70.0.3501.0
Bad build: 70.0.3502.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/61c2840f00243135c7f22504ba0d8147db68b856..124f80f9c6f0935ed1369617346443d4321427bf

suspect: https://chromium.googlesource.com/chromium/src/+/124f80f9c6f0935ed1369617346443d4321427bf

Reviewed-on: https://chromium-review.googlesource.com/1147157

rsesek:Please confirm the issue and help in re-assigning if it is not related to your change.Adding RBS lable for M-70 feel free to change it if not reuired.

Thanks!

Comment 2 by ellyjo...@chromium.org, Jul 26

Owner: ellyjo...@chromium.org
rsesek@'s CL is unrelated - I introduced this bug.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f759a3174d17ee4d575f4937044349b8878ad655

commit f759a3174d17ee4d575f4937044349b8878ad655
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Jul 26 20:08:45 2018

ui: use literal commas and periods in accelerators on Mac

That is, accelerators should read ",", not "Comma".

Bug:  867732 
Change-Id: I7dec0af8475b420cbc4e793fecc823378b04f3ad
Reviewed-on: https://chromium-review.googlesource.com/1151649
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578411}
[modify] https://crrev.com/f759a3174d17ee4d575f4937044349b8878ad655/ui/base/accelerators/accelerator.cc
[modify] https://crrev.com/f759a3174d17ee4d575f4937044349b8878ad655/ui/base/accelerators/accelerator_unittest.cc

Comment 5 by ellyjo...@chromium.org, Jul 27

Status: Fixed (was: Started)
►

Sign in to add a comment