Constraints are breaking on TabGrid at App Launch |
||||||||
Issue descriptionI think we should prioritize this since resolving the constraints breakage takes time and it might delay startup time. These might have been caused by https://chromium-review.googlesource.com/c/chromium/src/+/1141287/13/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm Error messages: 2018-07-25 17:21:44.379078-0700 Chromium[2398:14139594] [LayoutConstraints] Unable to simultaneously satisfy constraints. Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. ( "<NSLayoutConstraint:0x60800029c7a0 recent_tabs_view_controll....width == UIView:0x7f97cdd216b0.width (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x60800029c890 H:[UIView:0x7f97cdc3d4b0]-(0)-[recent_tabs_view_controll...] (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x60800029c8e0 recent_tabs_view_controll....trailing == UIView:0x7f97cdc3d4b0.trailing (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x600000294730 H:[TabGridNewTabButton:0x7f97cdd36580]-(0)-[UIButton:0x7f97cdd2af50] (active)>", "<NSLayoutConstraint:0x6000002943c0 TabGridNewTabButton:0x7f97cdd36580.centerX == UIVisualEffectView:0x7f97cdc43fc0.centerX (active)>", "<NSLayoutConstraint:0x60800029dc90 H:|-(0)-[UIVisualEffectView:0x7f97cdc43fc0] (active, names: '|':TabGridBottomToolbar:0x7f97cdc3ea20 )>", "<NSLayoutConstraint:0x60800029dce0 UIVisualEffectView:0x7f97cdc43fc0.trailing == TabGridBottomToolbar:0x7f97cdc3ea20.trailing (active)>", "<NSLayoutConstraint:0x600000294780 UIButton:0x7f97cdd2af50.trailing == UILayoutGuide:0x6080001b5000'UIViewLayoutMarginsGuide'.trailing (active)>", "<NSLayoutConstraint:0x600000294af0 H:|-(0)-[TabGridBottomToolbar:0x7f97cdc3ea20] (active, names: '|':UIView:0x7f97cdd216b0 )>", "<NSLayoutConstraint:0x600000294b40 TabGridBottomToolbar:0x7f97cdc3ea20.trailing == UIView:0x7f97cdd216b0.trailing (active)>", "<NSLayoutConstraint:0x60800029de70 'UIView-rightMargin-guide-constraint' H:[UILayoutGuide:0x6080001b5000'UIViewLayoutMarginsGuide']-(16)-|(LTR) (active, names: '|':TabGridBottomToolbar:0x7f97cdc3ea20 )>" ) Will attempt to recover by breaking constraint <NSLayoutConstraint:0x600000294730 H:[TabGridNewTabButton:0x7f97cdd36580]-(0)-[UIButton:0x7f97cdd2af50] (active)> Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger. The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful. 2018-07-25 17:21:44.495486-0700 Chromium[2398:14139594] [LayoutConstraints] Unable to simultaneously satisfy constraints. Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. ( "<NSLayoutConstraint:0x60800029c7a0 recent_tabs_view_controll....width == UIView:0x7f97cdd216b0.width (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x60800029c890 H:[UIView:0x7f97cdc3d4b0]-(0)-[recent_tabs_view_controll...] (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x60800029c8e0 recent_tabs_view_controll....trailing == UIView:0x7f97cdc3d4b0.trailing (active, names: recent_tabs_view_controll...:0x7f97d082f800 )>", "<NSLayoutConstraint:0x60c000289ce0 'UIView-Encapsulated-Layout-Width' UIView:0x7f97cdd216b0.width == 375 (active)>" )
,
Jul 26
,
Jul 26
[viewController.view.leadingAnchor constraintEqualToAnchor:parentView.trailingAnchor] should be [viewController.view.leadingAnchor constraintEqualToAnchor:parentView.leadingAnchor],
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83bfa572f9bfa2f303f3f79f6cda5f1bf46ad105 commit 83bfa572f9bfa2f303f3f79f6cda5f1bf46ad105 Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Jul 26 21:55:32 2018 [ios] Fix Constraints between Recent Tabs and Parent View in TabGrid Bug: 867717 Change-Id: I85bd1f1c0404e536236a6b08787da499a5d7da41 Reviewed-on: https://chromium-review.googlesource.com/1152107 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#578449} [modify] https://crrev.com/83bfa572f9bfa2f303f3f79f6cda5f1bf46ad105/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 27
,
Jul 27
I'm guessing this needs to be merged? Please add label and get canary verification.
,
Jul 27
,
Jul 27
This one is hard to verify since it's just clearing out a constraint conflict, which can be seen on the Xcode console really. But I am 100% it's there.
,
Jul 28
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
Manually approved as well.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b0fd9cdcb70ebe12ea6ef86cf0d35aecc988fc commit a7b0fd9cdcb70ebe12ea6ef86cf0d35aecc988fc Author: sczs <sczs@chromium.org> Date: Mon Jul 30 18:27:33 2018 [ios] Fix Constraints between Recent Tabs and Parent View in TabGrid TBR=thegreenfrog@chromium.org (cherry picked from commit 83bfa572f9bfa2f303f3f79f6cda5f1bf46ad105) Bug: 867717 Change-Id: I85bd1f1c0404e536236a6b08787da499a5d7da41 Reviewed-on: https://chromium-review.googlesource.com/1152107 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578449} Reviewed-on: https://chromium-review.googlesource.com/1155377 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#222} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/a7b0fd9cdcb70ebe12ea6ef86cf0d35aecc988fc/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by marq@chromium.org
, Jul 26Labels: -Restrict-View-Google MS-Tab-Grid M-69
Owner: thegreenfrog@chromium.org
Status: Assigned (was: Untriaged)