New issue
Advanced search Search tips

Issue 867708 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTest produces unhandled promise rejections

Reported by m...@bocoup.com, Jul 26

Issue description

A LayoutTest named `call-extra-crash-is-locked.html` [1] is expected to cause
unhandled promise rejections. Although the test harness reports an error when
it detects unhandled promise rejections, they do not occur in this test until
results have already been reported.

In a forthcoming change to testharness.js[2], testing will pause until
"cleanup" code has completed. This change will delay the reporting of results,
and the previously-ignored unhandled rejections will interrupt the results.

Ideally, the rejections could be handled with explicit code written for this
purpose. The particulars of the test in question make this impossible. Because
of this, the test harness should be configured to allow unhandled promise
rejections.

[1] third_party/WebKit/LayoutTests/http/tests/fetch/chromium/call-extra-crash-is-locked.html
[2] https://github.com/web-platform-tests/wpt/pull/8748
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882078debb3e3da6192957f8f910d2733866b10a

commit 882078debb3e3da6192957f8f910d2733866b10a
Author: Mike Pennisi <mike@mikepennisi.com>
Date: Fri Jul 27 22:27:44 2018

Allow unhandled promise rejection in LayoutTest

This test is expected to cause unhandled promise rejections. Although
the test harness reports an error when it detects unhandled promise
rejections, they do not occur in this test until results have already
been reported.

In a forthcoming change to testharness.js [1], testing will pause until
"cleanup" code has completed. This change will delay the reporting of
results, and the previously-ignored unhandled rejections will interrupt
the results.

Ideally, the rejections could be handled with explicit code written for
this purpose. The particulars of this test make this impossible.
Instead, configure the test harness to allow unhandled promise
rejections.

[1] https://github.com/web-platform-tests/wpt/pull/8748

R=foolip@chromium.org, robertma@chromium.org

Bug:  867708 
Change-Id: I7ac53d88424e80b89e9969312f8cbfeb0922f579
Reviewed-on: https://chromium-review.googlesource.com/1150882
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578830}
[modify] https://crrev.com/882078debb3e3da6192957f8f910d2733866b10a/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/call-extra-crash-is-locked.html

Cc: ricea@chromium.org
Components: Blink>Network>FetchAPI
Owner: ricea@chromium.org
Status: Assigned (was: Unconfirmed)
Can this be closed now?
Status: Fixed (was: Assigned)

Sign in to add a comment