Stop building closure compiler from scratch |
||||
Issue descriptionPasting from the TODO at [1] we don't really need to build the compiler any more. We used to need to because we built a custom runner. We could probably just curl https://dl.google.com/closure-compiler/compiler-latest.zip and unzip. And get the externs from rawgit.com. [1] https://cs.chromium.org/chromium/src/third_party/closure_compiler/roll_closure_compiler?l=9 [2] https://codereview.chromium.org/2629323002
,
Sep 8
Candidate CL at https://chromium-review.googlesource.com/c/chromium/src/+/1214746.
,
Sep 8
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/218262850a704dcaa9e9fb51393d5b8dd143b2a4 commit 218262850a704dcaa9e9fb51393d5b8dd143b2a4 Author: dpapad <dpapad@chromium.org> Date: Tue Sep 11 17:40:39 2018 WebUI: Stop compiling Closure compiler, just download it instead. Historically the Closure compiler was compiled from scratch, because it was modified to include a Chrome-specific pass. ChromePass.java has been upstreamed to the canonical repo for a while now, so there is no need to keep building the compiler from scratch anymore (as of r445661) Benefits: Rolling a new Closure compiler version is now much - Faster (before it took a few minutes, now it takes a few seconds). - Easier (no more dependencies to mvn and jdk, no setup required) Cons: - No automated changelog link between previous and new versions. - Can't pull in closure-compiler master branch anymore, instead only what's at https://dl.google.com/closure-compiler/compiler-latest.zip is available. This CL also rolls a new Closure compiler version as a proof that the new roll_closure_compiler script works. Bug: 867683 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I19671593a32c379ce9c3fb919f889aab56d939cf Reviewed-on: https://chromium-review.googlesource.com/1214746 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590377} [modify] https://crrev.com/218262850a704dcaa9e9fb51393d5b8dd143b2a4/third_party/closure_compiler/README.chromium [modify] https://crrev.com/218262850a704dcaa9e9fb51393d5b8dd143b2a4/third_party/closure_compiler/compiler/compiler.jar [modify] https://crrev.com/218262850a704dcaa9e9fb51393d5b8dd143b2a4/third_party/closure_compiler/externs/chrome_extensions.js [modify] https://crrev.com/218262850a704dcaa9e9fb51393d5b8dd143b2a4/third_party/closure_compiler/externs/polymer-1.0.js [modify] https://crrev.com/218262850a704dcaa9e9fb51393d5b8dd143b2a4/third_party/closure_compiler/roll_closure_compiler
,
Sep 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Sep 8Status: Assigned (was: Available)