New issue
Advanced search Search tips

Issue 867647 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Frozen tab that receive a navigation event should be unfreeze.

Project Member Reported by sebmarchand@chromium.org, Jul 25

Issue description

It's possible to reload a frozen tab (by right-clicking and selecting reload on it), currently these tabs will stay in the frozen state and load forever, they should be unfreeze as there's been a direct user interaction with them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1271dc544271f29bde796e2ccebe7adec6a4242

commit c1271dc544271f29bde796e2ccebe7adec6a4242
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Jul 31 20:58:49 2018

RC: Allow the Frozen->Active user-initiated transitions.

This makes TabManager aware of the navigation events happening on a
frozen tab (e.g. by right-clicking + choosing reload on a frozen tab).

Bug: 775644,  867647 
Change-Id: I3877a40884f4c365390202bd5a1d696b17c69b54
Reviewed-on: https://chromium-review.googlesource.com/1133958
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579561}
[modify] https://crrev.com/c1271dc544271f29bde796e2ccebe7adec6a4242/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/c1271dc544271f29bde796e2ccebe7adec6a4242/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/c1271dc544271f29bde796e2ccebe7adec6a4242/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Labels: Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 2

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: gov...@chromium.org
govind@: FYI what I'm asking to merge here is a simple CL that fix some minor issues with the Proactive Tab Discarding feature. It has a really low risk of breaking things and the entire feature is behind a flag anyway, the data we get from Beta will help us decide if we move on to Stable or not.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #4. Pls merge ASAP. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2e2a73c1f083ba8608d77cf4d74a7c3d9df705c

commit b2e2a73c1f083ba8608d77cf4d74a7c3d9df705c
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu Aug 02 20:00:57 2018

RC: Allow the Frozen->Active user-initiated transitions.

This makes TabManager aware of the navigation events happening on a
frozen tab (e.g. by right-clicking + choosing reload on a frozen tab).

Bug: 775644,  867647 
Change-Id: I3877a40884f4c365390202bd5a1d696b17c69b54
Reviewed-on: https://chromium-review.googlesource.com/1133958
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579561}(cherry picked from commit c1271dc544271f29bde796e2ccebe7adec6a4242)
Reviewed-on: https://chromium-review.googlesource.com/1161124
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#349}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/b2e2a73c1f083ba8608d77cf4d74a7c3d9df705c/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/b2e2a73c1f083ba8608d77cf4d74a7c3d9df705c/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/b2e2a73c1f083ba8608d77cf4d74a7c3d9df705c/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment