Picture-in-Picture: (Windows only) after resizing, the controls do not show up again |
||||||||||
Issue descriptionChrome Version : 69.0.3493.3 OS Version: Windows What steps will reproduce the problem? 1. Play a video in PIP 2. Resize window 3. Move mouse back in window What is the expected result? Play/pause button come back What happens instead of that? Play/pause button do not show up again
,
Jul 26
,
Jul 26
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec commit dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Jul 26 05:30:18 2018 Picture-in-Picture: show buttons when the mouse is hovering. This is fixing a Windows specific bug where the ENTER event isn't fired. Bug: 867646 Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 Reviewed-on: https://chromium-review.googlesource.com/1150892 Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578212} [modify] https://crrev.com/dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e555bedbd7a0667165b9e459aa1058e0f2c28d56 commit e555bedbd7a0667165b9e459aa1058e0f2c28d56 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Jul 26 15:14:24 2018 Revert "Picture-in-Picture: show buttons when the mouse is hovering." This reverts commit dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec. Reason for revert: <INSERT REASONING HERE> Original change's description: > Picture-in-Picture: show buttons when the mouse is hovering. > > This is fixing a Windows specific bug where the ENTER event isn't fired. > > Bug: 867646 > Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 > Reviewed-on: https://chromium-review.googlesource.com/1150892 > Reviewed-by: apacible <apacible@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578212} TBR=mlamouri@chromium.org,apacible@chromium.org Change-Id: Ied59d027a5fb261ac3c436dacf2ba074e05dc773 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867646 Reviewed-on: https://chromium-review.googlesource.com/1150703 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578308} [modify] https://crrev.com/e555bedbd7a0667165b9e459aa1058e0f2c28d56/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Jul 26
Issue 867883 has been merged into this issue.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74cf944b493028ebb2d851eed384122b4a74f8ea commit 74cf944b493028ebb2d851eed384122b4a74f8ea Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Jul 26 21:51:43 2018 Reland "Picture-in-Picture: show buttons when the mouse is hovering." This is a reland of dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec Original change's description: > Picture-in-Picture: show buttons when the mouse is hovering. > > This is fixing a Windows specific bug where the ENTER event isn't fired. > > Bug: 867646 > Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 > Reviewed-on: https://chromium-review.googlesource.com/1150892 > Reviewed-by: apacible <apacible@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578212} Bug: 867646 Change-Id: I84dc563d7339b6146803a84b73deddbf720662c8 Reviewed-on: https://chromium-review.googlesource.com/1150704 Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578448} [modify] https://crrev.com/74cf944b493028ebb2d851eed384122b4a74f8ea/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Jul 26
,
Jul 27
Able to reproduce this issue on reported version hence verifying the fix on latest canary 70.0.3504.0 using Windows 10. Now controls are seen after resizing. Attaching screen-cast for reference. As fix is working as expected adding Verified labels. Thanks!
,
Jul 27
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
Approving merge to M69 branch 3497 for CL listed at #7 based on comment #9. Please merge latest by Monday morning so we can pick it up for next week M69 Dev/Beta release. Thank you.
,
Jul 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/668f6b9c00b65eecb6caba2f76b9ea4561b11b56 commit 668f6b9c00b65eecb6caba2f76b9ea4561b11b56 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Sun Jul 29 22:04:58 2018 Reland "Picture-in-Picture: show buttons when the mouse is hovering." This is a reland of dab9cc046da22d8f51cc8bf7c4a44a32c24e4fec Original change's description: > Picture-in-Picture: show buttons when the mouse is hovering. > > This is fixing a Windows specific bug where the ENTER event isn't fired. > > Bug: 867646 > Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 > Reviewed-on: https://chromium-review.googlesource.com/1150892 > Reviewed-by: apacible <apacible@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578212} Bug: 867646 Change-Id: I84dc563d7339b6146803a84b73deddbf720662c8 Reviewed-on: https://chromium-review.googlesource.com/1150704 Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578448}(cherry picked from commit 74cf944b493028ebb2d851eed384122b4a74f8ea) Reviewed-on: https://chromium-review.googlesource.com/1154152 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#190} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/668f6b9c00b65eecb6caba2f76b9ea4561b11b56/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Jul 29
,
Aug 1
Able to reproduce this issue on build without fix, hence verifying the issue on latest Dev #69.0.3497.23 using Windows 10. Now controls are seen after resizing. Attaching screen-cast for reference. As fix is working as expected adding Verified labels. Thanks! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mlamouri@chromium.org
, Jul 26