New issue
Advanced search Search tips

Issue 867643 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-07
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[πŸ“] Remove deprecated code

Project Member Reported by dtu@chromium.org, Jul 25

Issue description

A few months from now, remove any code that's related to:
* The ChartJson to HistogramSet migration (go/catabug/4243)
* Support for internal Swarming and Isolate servers (issue 822008)
* OBBS migration from telemetry_perf_tests to performance_test_suite (various)

Most of it is marked with TODOs.
 
The NextAction date has arrived: 2019-01-07
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/eb81d534be5cfbf7453874644c686781a5cd6682

commit eb81d534be5cfbf7453874644c686781a5cd6682
Author: Dave Tu <dtu@chromium.org>
Date: Thu Jan 10 23:24:55 2019

[pinpoint] Remove old code for OOBS and Swarming/Isolate server migrations.

Bug: chromium:867643
Change-Id: I662baaca1aea32cc346f62e9b31236df8bc2f52f
Reviewed-on: https://chromium-review.googlesource.com/c/1382810
Commit-Queue: Dave Tu <dtu@chromium.org>
Reviewed-by: Juan Antonio Navarro PΓ©rez <perezju@chromium.org>

[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_browser_test_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_performance_test_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/handlers/new_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_gtest_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_test_test.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/read_value.py
[modify] https://crrev.com/eb81d534be5cfbf7453874644c686781a5cd6682/dashboard/dashboard/pinpoint/models/quest/run_instrumentation_test_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db27da7fa66e91086096b2b6083870b2ddbe6d3f

commit db27da7fa66e91086096b2b6083870b2ddbe6d3f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 03:26:46 2019

Roll src/third_party/catapult 0cc582388fa2..0df132fe0a47 (6 commits)

https://chromium.googlesource.com/catapult.git/+log/0cc582388fa2..0df132fe0a47


git log 0cc582388fa2..0df132fe0a47 --date=short --no-merges --format='%ad %ae %s'
2019-01-11 benjhayden@chromium.org Use HistogramSet.ImportDicts in PageTestResults.
2019-01-11 benjhayden@chromium.org Use storyTags instead of tagMap in update_test_suite_descriptors.
2019-01-10 benjhayden@chromium.org Use the HTMLImports polyfill
2019-01-10 benjhayden@chromium.org Fix request-base-test with polyfilled html imports.
2019-01-10 dtu@chromium.org [pinpoint] Remove old code for OOBS and Swarming/Isolate server migrations.
2019-01-10 eroman@chromium.org Add mattm to OWNERS for netlog_viewer.


Created with:
  gclient setdep -r src/third_party/catapult@0df132fe0a47

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918208,chromium:918218,chromium:867643
TBR=sullivan@chromium.org

Change-Id: I3ea68899d4f9fa4b5896f792ef2fc7f616cee8c2
Reviewed-on: https://chromium-review.googlesource.com/c/1406264
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621888}
[modify] https://crrev.com/db27da7fa66e91086096b2b6083870b2ddbe6d3f/DEPS

Sign in to add a comment