skylab_suite: get the correct swarming URL create child tasks from bot env |
||
Issue descriptionCurrently, this is hard-coded: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/venv/skylab_suite/swarming_lib.py#22 This means that we can't have a staging setup running skylab_suite (children task will still end up on the prod Swarming instance) Instead of hard-coding, there are two options: - The swarming bot gets the current swarming instance from environment variables (set by the swarming bot code) and uses that. - The swarming instance to use is somehow set by puppet on the skylab-suite-proxy servers, and that is used. Your pick. Note that none of the constants in that block should be hard-coded. They should all be deployed via puppet. But this one blocks staging work.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dbeaf7e68b05d832e62e25c55123becd1db441c2 commit dbeaf7e68b05d832e62e25c55123becd1db441c2 Author: Xixuan Wu <xixuan@chromium.org> Date: Thu Jul 26 16:03:23 2018 autotest: Use the same SWARMING_SERVER for child tasks as the suite task. BUG= chromium:867638 TEST=Ran './swarming.py run --swarming https://chrome-swarming.appspot.com --task-summary-json /tmp/temp_summary_no_logging_info.json --raw-cmd --dimension pool ChromeOSSkylab-suite --dimension id cros-skylab-suite-server1-5 '--tags=luci_project:chromiumos' -- /usr/local/autotest/bin/run_suite_skylab --build nyan_blaze-release/R69-10763.0.0 --board nyan_blaze --suite_name sanity' locally. Change-Id: I5a04dee19b21db197dcce09f9a7b4ed64bb36703 Reviewed-on: https://chromium-review.googlesource.com/1150761 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/dbeaf7e68b05d832e62e25c55123becd1db441c2/venv/skylab_suite/swarming_lib.py
,
Jul 27
|
||
►
Sign in to add a comment |
||
Comment 1 by pprabhu@chromium.org
, Jul 25