Issue metadata
Sign in to add a comment
|
Delete button is cut off when device orientation is changed. |
||||||||||||||||||||||
Issue descriptionApp Version: 69.03497.13 beta iOS Version: 11.4, 12 Device: iPhone X, iPhone6 PreCondition: Have a few reading list items under reading list Steps to reproduce: 1. Launch Chrome app 2. Go to Reading List , Change device orientation to landscape mode. 3. Swipe the reading list item to bring up the delete option. 4. Change device orientation to portrait mode. Observed results: Delete button is cut off when device orientation is changed. Expected results: Delete button should not be cut off. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/1Q7U0lVQmihu381a68OxgEAVRJAWDM2M9/view?usp=sharing
,
Jul 26
,
Aug 6
,
Aug 31
,
Aug 31
,
Aug 31
,
Sep 4
Fixed. Setting next action date for canary verification.
,
Sep 5
The NextAction date has arrived: 2018-09-05
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318302e7d5a8e798bd617bc1e3a473d20ad70368 commit 318302e7d5a8e798bd617bc1e3a473d20ad70368 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Sep 04 19:24:45 2018 [iOS] Cancel uncommitted swipe-to-delete gesture upon rotation. There is a bug in UITableView where rotating a UITableView with an uncommitted swipe edit will break the layout of that cell. Even after cancelling the swipe gesture by swiping right on the cell, the horizontal positioning of the cell's content view remains broken. This CL exits editing mode upon rotation if it's caused by the swipe gesture. The table view will remain in editing mode if editing was initiated via the toolbar buttons, as this does not produce the same layout issue. Bug: 867637 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I187ea3545a8d65efaba8fc01f9d4676ae2aa57ae Reviewed-on: https://chromium-review.googlesource.com/1200314 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588609} [modify] https://crrev.com/318302e7d5a8e798bd617bc1e3a473d20ad70368/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Sep 6
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e7cb28e30123aabbc2aeae2bf652f700f4d808 commit f2e7cb28e30123aabbc2aeae2bf652f700f4d808 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Mon Sep 10 18:22:01 2018 [iOS] Cancel uncommitted swipe-to-delete gesture upon rotation. There is a bug in UITableView where rotating a UITableView with an uncommitted swipe edit will break the layout of that cell. Even after cancelling the swipe gesture by swiping right on the cell, the horizontal positioning of the cell's content view remains broken. This CL exits editing mode upon rotation if it's caused by the swipe gesture. The table view will remain in editing mode if editing was initiated via the toolbar buttons, as this does not produce the same layout issue. Bug: 867637 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I187ea3545a8d65efaba8fc01f9d4676ae2aa57ae Reviewed-on: https://chromium-review.googlesource.com/1200314 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588609}(cherry picked from commit 318302e7d5a8e798bd617bc1e3a473d20ad70368) Reviewed-on: https://chromium-review.googlesource.com/1216719 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#231} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/f2e7cb28e30123aabbc2aeae2bf652f700f4d808/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Sep 11
Verified in 71.0.3549.0 Canary in iPhone X(iOS 11.4.1), iPhone 6s plus(iOS 12 beta 12) and iPhone7(iOS 11.4.1) The edit mode is now dismissed on device orientation. Looks good Link to video: https://drive.google.com/file/d/1y26CBCpbzlcp1f4ULFKkErF4epPf-EnM/view?usp=sharing
,
Sep 14
Verified in 70.0.3538.17 Beta in iPhone 6s plus(iOS 12 beta 12) and iPhone6 plus(iOS 11.4.1) The edit mode is now dismissed on device orientation. Looks good |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jul 26Labels: q4
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)