New issue
Advanced search Search tips

Issue 867625 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"VideoTrackRecorderTest.HandlesOnError" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 25

Issue description

"VideoTrackRecorderTest.HandlesOnError" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVWaWRlb1RyYWNrUmVjb3JkZXJUZXN0LkhhbmRsZXNPbkVycm9yDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe

commit a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe
Author: Yoichi Osato <yoichio@chromium.org>
Date: Thu Jul 26 03:13:31 2018

Revert "[Media Recorder] Fix video freeze on short recording. Fix tab crash on initialize."

This reverts commit 556813c93fa177cdb275674bdd1016f75e674f47.

Reason for revert: LeakSanitizer detected memory leaks
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940004334055018640/+/steps/content_unittests__with_patch_/0/logs/VideoTrackRecorderTest.HandlesOnError/0

Original change's description:
> [Media Recorder] Fix video freeze on short recording. Fix tab crash on initialize.
> 
> Fixes an issue where VideoTrackRecorder when used in combination with
> VEAEncoder and very short recording durations (just 1 frame) would
> occasionally hold on to video frames forever, causing frame buffers
> from the buffer pool to become permanently blocked, eventually leading
> to video capture freezing.
> 
> The cause was a circular ownership that would happen if only 1 frame
> is recorded.
> 
> This CL additionally fixes a crash that could happen on initialization
> of VEAEncoder. This issue was revealed during testing of the above fix.
> Since it is not 100% if this crash was masked by the other issue, and
> would only start occurring with the above fix, I am making a fix for that
> part of this CL as well.
> 
> The cause for the crash issue was that class VEAEncoder, which uses
> RefCountedThreadSafe<>, would post an asynchronous task from its
> constructor. If this task would finish executing before the newly
> constructed instance was assigned to a scoped_refptr<> by however
> called the constructor, the instance would destroy itself, because
> of the AddRef() and subsequent Release() done by the posting and
> running of the asynchronous task.
> 
> The fix for this is to use a new method Initialize() instead of
> posting a task from the constructor.
> 
> Bug:  859610 
> Change-Id: I6645aebfaa7659ab0ced0a20fae57eedfb9d84ab
> Reviewed-on: https://chromium-review.googlesource.com/1145877
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577735}

TBR=emircan@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  859610 ,867625
Change-Id: If3fed5676c76da0d6b6ef6a041d74c782e87ebf3
Reviewed-on: https://chromium-review.googlesource.com/1150947
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578181}
[modify] https://crrev.com/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe/content/renderer/media_recorder/vea_encoder.cc
[modify] https://crrev.com/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe/content/renderer/media_recorder/vea_encoder.h
[modify] https://crrev.com/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/a9fb21d345e9fcc11105b1d33a3cb5c8b27bcafe/content/renderer/media_recorder/video_track_recorder_unittest.cc

Labels: -Sheriff-Chromium

Sign in to add a comment