Passphrase info bar disappears on opening new tab from tab switcher mode |
|||||||||||
Issue descriptionApp Version: 69.03497.13 beta iOS Version: 10.3.3, 11.4.1 Device: iPhone 5S, iPhone X Steps to reproduce: 1. Launch chrome and sign in with the account having passphrase 2. Go to tab switcher mode 3. Tap on + icon Observed results: Passphrase info bar disappears on opening new tab from tab switcher mode Expected results: Passphrase info bar should not disappear when opening new tab from tab switcher mode Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes/No Bug reproducible after clearing cache and cookies: Yes/No Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No M68 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69 Link Video: https://drive.google.com/file/d/1QriAQDNN-5JztCrCcJPR99ym-uAlmzzn/view
,
Jul 26
cc. jlebel for signin
,
Jul 27
,
Jul 30
Verified that on M68, the "Passphrase" infobar should appear with every created New Tab Page. This is not happening with ToT.
,
Jul 30
There are 3 ways to create a New Tab Page: 1. Tools > [+] New Tab 2. Long tap on Tab Grid icon > [+] New Tab 3. Tab Grid > (+) icon in the middle NTP created with 1 & 2 shows the "Passphrase" infobar. NTP created with 3 does not.
,
Jul 30
When a new tab is added through 1 or 2, BVC runs -tabModel:didChangeActiveTab:previousTab:atIndex: which adds the SyncErrorInfoBar. When a new tab is added through Tab Grid, the BVC isn't there and thus the SyncErrorInfoBar is not added. When BVC is eventually created, the Infobar creation code is not run and thus no Infobar.
,
Jul 31
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/778af7b9a2f1d7e7190ad64a7b6394f47293cffc commit 778af7b9a2f1d7e7190ad64a7b6394f47293cffc Author: Peter K. Lee <pkl@chromium.org> Date: Wed Aug 01 19:25:48 2018 Use NavigationManager to load NTP for new tabs from Tab Grid This unifies the addition of a new Tab to WebStateList in Tab Grid with that used in Tools menu and long tap menu of the Tab Grid icon on the bottom toolbar. See tab_model.mm -insertTabWithLoadParams:opener:openedByDOM:atIndex:inBackground:. In order to have InfoBars added to a New Tab Page, new page must be loaded before added to WebStateList because the latter triggers the observers. Bug: 867623 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia5f3b0ee4a70bebd6713e5c8e242edd36d8f8ce5 Reviewed-on: https://chromium-review.googlesource.com/1157552 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#579895} [modify] https://crrev.com/778af7b9a2f1d7e7190ad64a7b6394f47293cffc/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm [modify] https://crrev.com/778af7b9a2f1d7e7190ad64a7b6394f47293cffc/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
,
Aug 1
,
Aug 1
Waiting for Canary verification on Thursday morning.
,
Aug 2
Verified with 70.0.3510.0 canary by signing into bling.test.13@gmail.com account. Requesting merge to M69 (3497) branch now.
,
Aug 2
Approved.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/938d0c9cd575eadf2f87910589dfa4ec7bd48c65 commit 938d0c9cd575eadf2f87910589dfa4ec7bd48c65 Author: Peter K. Lee <pkl@chromium.org> Date: Thu Aug 02 17:50:05 2018 Use NavigationManager to load NTP for new tabs from Tab Grid This unifies the addition of a new Tab to WebStateList in Tab Grid with that used in Tools menu and long tap menu of the Tab Grid icon on the bottom toolbar. See tab_model.mm -insertTabWithLoadParams:opener:openedByDOM:atIndex:inBackground:. In order to have InfoBars added to a New Tab Page, new page must be loaded before added to WebStateList because the latter triggers the observers. Bug: 867623 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia5f3b0ee4a70bebd6713e5c8e242edd36d8f8ce5 Reviewed-on: https://chromium-review.googlesource.com/1157552 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579895}(cherry picked from commit 778af7b9a2f1d7e7190ad64a7b6394f47293cffc) Reviewed-on: https://chromium-review.googlesource.com/1160943 Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#341} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/938d0c9cd575eadf2f87910589dfa4ec7bd48c65/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm [modify] https://crrev.com/938d0c9cd575eadf2f87910589dfa4ec7bd48c65/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
,
Aug 7
Verified on iPhone7Plus, iOS:10.3.3 M70.0.3515.0 canary
,
Aug 8
Verified in build 69.0.3497.31 Beta on iPhoneX iOS 11.4, iPhone 7+ iOS 10.3.3 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 26Status: Assigned (was: Untriaged)