New issue
Advanced search Search tips

Issue 867617 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Previous locations:
gerrit:9484


Sign in to add a comment

"Choose Tryjob" missing for me

Project Member Reported by brat...@opera.com, Jul 25

Issue description

I had to run some special trybots for a change and realized, after investigating how, that the "CHOOSE TRYJOBS" link is missing for me in for instance https://chromium-review.googlesource.com/c/chromium/src/+/1150235

A suspicion is that there is a stray 'if email.endswith("chromium.org")' somewhere in the code.



 
No 'choose tryjob'.png
8.0 KB View Download
Project: chromium
Moved issue gerrit:9484 to now be  issue chromium:867617 .
Components:
oscarj@opera.com seems to have that link. Maybe it's just a problem with my account.
Components: Infra>Codereview
Cc: dpranke@chromium.org
Summary: "Choose Tryjob" missing for me (was: "Choose Tryjob" missing)
dpranke, is it possible to do a quick check that my account is configured correctly? It's been in the project for a while so there could be something archaic with it.
Cc: tandrii@chromium.org
It looks like it should be configured correctly. 

Sometimes loading the tryjobs plugin seems to be buggy or racy. 

Maybe bump this bug if this is still happening for you next week, and we can look into it more?
Ugh, this just happened to me on my laptop. Logged in as atotic@chromium.

Weird thing is that I used this laptop last night, and everything worked.

Tryjobs are completely gone: can't view, select new ones
Also gone: ability to resubmit my CL.


top.png
177 KB View Download
middle.png
130 KB View Download

Comment 7 Deleted

Same thing happening on my desktop. The only way I was able to try and commit was by using "Reply" button, and then setting the "+2" button on commit queue.

This worked. 

Console did not show any weird errors. When I set breakpoint on "catch any exceptions on load", I got:
"SyntaxError: Unexpected end of JSON input"
at _parsePrefixedJSON. 
source was "", so of course parse failed.

That was the only exception in JS on loading.

My guess is that something somewhere is returning invalid value, which causes UI hiccup.

Looking at Network responses for anything suspicious, nothing jumps out. If anyone knows which response should contain tryjobs information, I can take a look.

Only suspicious one is "detail". It is empty. Everyone else is prefixed by ')]}'


also, "?download=commands" is empty.
today it's broken for a diff reason, see  issue 872722 

but please don't dedup. as root cause of this original bug report is sitll unknown.
Is there any debugging I can do from the client side (since I'm able to reproduce)?
Components: -Infra>Codereview Infra>Codereview>Gerrit
+nodir@
Components: -Infra>Codereview>Gerrit Infra>Platform>Buildbucket>Gerrit
 Issue 840582  has been merged into this issue.
Cc: cbiesin...@chromium.org
From crbug/840582#c8, it looked like maybe getting LUCI migration state was an/the error. Looking at the luci-migration logs, there are some OAUTH_INVALID_TOKENS errors corresponding with those masters, though I'm unsure how relevant that is/if that's where the root cause is.
Owner: no...@chromium.org
Status: Started (was: New)
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/a89bedf507ab86c516f78ae6c93af2aeeffb1f7c

commit a89bedf507ab86c516f78ae6c93af2aeeffb1f7c
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 17 22:30:14 2018

[buildbucket] Check token validity

Before returning a cached access token, check its validity, specifically
expiration.

Bug: 870706,  867617 
Change-Id: Ibfa030eaff6c46187315e2c500b75a41ff72287e
Reviewed-on: https://chromium-review.googlesource.com/1228431
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/a89bedf507ab86c516f78ae6c93af2aeeffb1f7c/src/main/resources/static/cr-buildbucket-client.js

Labels: Pri-2 Type-Bug
Looking forward to being able to choose tryjobs. :)

It's not been deployed yet, right? The button is still missing for me. And I do wonder if I could really have had an expired token in the cache for months.
cached token is stored in a variable, so unless you didn't refresh your page for months, the CL won't help.

here is some debugging you could do:
- please open Network tab and see if you have requests to cr-buildbucket.appspot.com. 
  That's where builds are fetched from. Normally you'd see search RPCs every 5 sec
- do you have cookies enabled? This is required for auth to work
- try setting a breakpoint in function "searchBuilds" in cr-buildbucket-client.js. Is it hit? Is this._sharedAuthState.token set? (don't paste its value here, it contains your credentials)

Status: Fixed (was: Started)
It was ad/privacy extensions that caused it. I'm sorry for the work I have caused. :-(

EFF's Privacy Badger removed some cross-domain cookies (I think) and Ghostery classified the button itself as a "Social Media Tracker (Google+ Platform)" and hid it. If I whitelist the site in both extensions, the buttons appear just fine.

🎉

Sign in to add a comment