New issue
Advanced search Search tips

Issue 867612 link

Starred by 1 user
Status: Fixed
Owner:
lanwei@chromium.org
Closed: Aug 7
Cc:
nzolghadr@chromium.org
Components:
EstimatedDays: 0
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Some pointer properties are missing while pen is touching the digitizer

Project Member Reported by lanwei@chromium.org, Jul 25 
After we switched to treat pen inputs like touch inputs, we found out that there are some
pointer properties missing such as twist, tangential pressure. Because we send touch events when the pen is contacting the digitizer, these attributes are lost when converting ui::touchevent to WebTouchEvent. We should add these attributes to MotionEvent.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72153c86ff7e9999d39a069903c943fb29f53056

commit 72153c86ff7e9999d39a069903c943fb29f53056
Author: lanwei <lanwei@chromium.org>
Date: Fri Aug 03 14:06:30 2018

Add some pointer properties to MotionEvent

We are using touch events to handle pen inputs, and when we convert
ui::touchevent to WebTouchEvent, some of the pointer properties are not
carried to WebPointerProperties. Because ui::touchevent are converted
to MotionEvent first, which does not have these attributes. Now we are
adding them to MotionEvent to pass these values to WebTouchEvent.

Bug:  867612 

Change-Id: I44a262f0810791169cf2dae45c9131b8bb708927
Reviewed-on: https://chromium-review.googlesource.com/1150578
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580531}
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/content/browser/renderer_host/input/motion_event_web.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/content/browser/renderer_host/input/motion_event_web.h
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/content/browser/renderer_host/input/motion_event_web_unittest.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/android/motion_event_android.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/android/motion_event_android.h
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/gesture_detection/motion_event.h
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/gesture_detection/motion_event_generic.cc
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/gesture_detection/motion_event_generic.h
[modify] https://crrev.com/72153c86ff7e9999d39a069903c943fb29f53056/ui/events/gestures/motion_event_aura.cc

Comment 2 by lanwei@chromium.org, Aug 7

Status: Fixed (was: Started)
►

Sign in to add a comment