New issue
Advanced search Search tips

Issue 867609 link

Starred by 1 user
Status: Fixed
Owner:
eirage@chromium.org
Closed: Aug 21
Cc:
nzolghadr@chromium.org
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

full precision on pointerevent offsetXY

Project Member Reported by eirage@chromium.org, Jul 25 
We shipped pointerevent fractional coordinates from M64.
However offsetX/Y(specced as double) are missed during the implementation and left as integer. 
We should the type of them as double and also provide unrounded version as other coordinates.

Comment 1 by eirage@chromium.org, Jul 31

Description: Show this description

Comment 2 by eirage@chromium.org, Jul 31

Summary: full precision on pointerevent offsetXY (was: full precision on pointerevent offsetXY and layerXY)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ecc34b0541127bf34989f7490ea4f905c1f3537

commit 2ecc34b0541127bf34989f7490ea4f905c1f3537
Author: Ella Ge <eirage@chromium.org>
Date: Wed Aug 15 17:21:30 2018

make pointerevent offsetx/y double

pointerevent fractional coordinates was shipped from M64, but
offsetx/y were left behind.
This CL makes them aligned with other coordinates, expose fractions
for pointerevents and rounded version for mouseevents.

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tl2sOodhtCs/oe0ZMNXPCAAJ

Bug:  867609 
Change-Id: I31af4ce01fa820e3281932e0b0a7e8bd5a6c0042
Reviewed-on: https://chromium-review.googlesource.com/1151534
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583297}
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/WebKit/LayoutTests/fast/events/offsetX-offsetY.html
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-mouse-coords-in-zoom-and-scroll.html
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-pen-coords-in-zoom-and-scroll.html
[add] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/WebKit/LayoutTests/virtual/mouseevent_fractional/fast/events/document-elementFromPoint-expected.txt
[add] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/WebKit/LayoutTests/virtual/mouseevent_fractional/fast/events/offsetX-offsetY-expected.txt
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/blink/renderer/core/events/mouse_event.h
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/blink/renderer/core/events/pointer_event.cc
[modify] https://crrev.com/2ecc34b0541127bf34989f7490ea4f905c1f3537/third_party/blink/renderer/core/events/pointer_event.h

Comment 4 by eirage@chromium.org, Aug 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment