Network Error Logging: Reports not generated for same-origin include_subdomains policies |
||||||
Issue descriptionIf a NEL policy has include_subdomains set, it can only be used to report errors that occur during DNS resolution — but only if the report origin and the policy origin are different. If they're the same (or, put another way, if the policy would be used even if include_subdomains wasn't set), then the policy should be able to be used to generate _any_ NEL report about the origin.
,
Jul 25
,
Jul 26
Pls apply appropriate OSs label. Thank you.
,
Jul 26
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f9ae242f6c368acfbd35cfdce499500836d78ea commit 3f9ae242f6c368acfbd35cfdce499500836d78ea Author: Douglas Creager <dcreager@chromium.org> Date: Fri Jul 27 15:08:21 2018 Network Error Logging: Ignore include_subdomains for same-origin reports The include_subdomains field in a NEL policy triggers special behavior: the policy can only be used to generate reports about DNS errors (and not about other kinds of errors, or about successful requests) — but only if the policy and report have different origins! If they have the same origin, the policy would have matched even if include_subdomains weren't set, and the special logic shouldn't apply. Bug: 867605 Change-Id: Iaa72c9dd2dc8e634f8b10acda8acc5e012bb460b Reviewed-on: https://chromium-review.googlesource.com/1150663 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578106}(cherry picked from commit 38267a5a7e21d74ef99d382a1e77cc4c8a979691) Reviewed-on: https://chromium-review.googlesource.com/1152648 Cr-Commit-Position: refs/branch-heads/3497@{#149} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/3f9ae242f6c368acfbd35cfdce499500836d78ea/net/network_error_logging/network_error_logging_service.cc [modify] https://crrev.com/3f9ae242f6c368acfbd35cfdce499500836d78ea/net/network_error_logging/network_error_logging_service_unittest.cc
,
Jul 27
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 25