New issue
Advanced search Search tips

Issue 867594 link

Starred by 1 user
Status: Assigned
Owner:
samans@chromium.org
Cc:
rjkroege@chromium.org
sadrul@chromium.org
kylec...@chromium.org
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve readability of viz::Display and viz::DisplayScheduler

Project Member Reported by samans@chromium.org, Jul 25 
Improve readability of viz::Display and viz::DisplayScheduler and along the way figure out what the hell is going on in these classes.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f0e3789b9d004c75fad28beaf478020ef2e0440

commit 0f0e3789b9d004c75fad28beaf478020ef2e0440
Author: Saman Sami <samans@chromium.org>
Date: Thu Jul 26 00:20:20 2018

Rename DisplayScheduler::SetRootSurfaceResourcesLocked

It just means root surface doesn't exist or doesn't have an active frame
so update the naming.

Bug: 867594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I42a4b5db05ef8168c31f6a2fd9b9694b8cf5200c
Reviewed-on: https://chromium-review.googlesource.com/1150613
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578139}
[modify] https://crrev.com/0f0e3789b9d004c75fad28beaf478020ef2e0440/components/viz/service/display/display.cc
[modify] https://crrev.com/0f0e3789b9d004c75fad28beaf478020ef2e0440/components/viz/service/display/display.h
[modify] https://crrev.com/0f0e3789b9d004c75fad28beaf478020ef2e0440/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/0f0e3789b9d004c75fad28beaf478020ef2e0440/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/0f0e3789b9d004c75fad28beaf478020ef2e0440/components/viz/service/display/display_scheduler_unittest.cc

Comment 2 by fsam...@chromium.org, Jul 26

Cc: rjkroege@chromium.org kylec...@chromium.org sadrul@chromium.org enne@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47f3e1c1640b4f49585850af36347a4ad290a7e8

commit 47f3e1c1640b4f49585850af36347a4ad290a7e8
Author: Saman Sami <samans@chromium.org>
Date: Thu Jul 26 21:15:42 2018

Add comments for BeginFrameDeadlineMode

Bug: 867594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6e3b94e187996b7b153932041074704bd2fb5895
Reviewed-on: https://chromium-review.googlesource.com/1150805
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578442}
[modify] https://crrev.com/47f3e1c1640b4f49585850af36347a4ad290a7e8/components/viz/service/display/display_scheduler.h
►

Sign in to add a comment