New issue
Advanced search Search tips

Issue 867556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] writes over the user entered data

Project Member Reported by parastoog@chromium.org, Jul 25

Issue description

https://passport.in.ckgs.us/get-started

Write sth on the first name. Trigger Autofill on last name. Autofill rewrites the first name.

Version:70.0.3503.0
 
Labels: M-69
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469

commit e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Mon Jul 30 15:11:58 2018

[Autofill] Keeping the user edit.

Problem:
When we Autofill, to decide if we should fill a field or leave it as
is, we check if the last edit was user's edit. If so, we would not
autofill (clear, etc). But sometimes, the website writes on the top
of the autofilled value (exp: formatting a phone number). So, if the
user adds a value on the field, the JS would edit it, and it would be
overwritten by autofill.
Solution:
Instead of looking at the last edit, look if the user has
ever edited that field.

Bug:  860542 ,  867556 
Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa
Reviewed-on: https://chromium-review.googlesource.com/1150683
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#579038}
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/public/web/web_form_control_element.h
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/exported/web_form_control_element.cc
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/html/forms/text_control_element.h

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2171da0f30ec3b712f4d23363c5950d38a8a140b

commit 2171da0f30ec3b712f4d23363c5950d38a8a140b
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Jul 31 19:42:18 2018

Merge-69 [Autofill] Keeping the user edit.

Problem:
When we Autofill, to decide if we should fill a field or leave it as
is, we check if the last edit was user's edit. If so, we would not
autofill (clear, etc). But sometimes, the website writes on the top
of the autofilled value (exp: formatting a phone number). So, if the
user adds a value on the field, the JS would edit it, and it would be
overwritten by autofill.
Solution:
Instead of looking at the last edit, look if the user has
ever edited that field.

Bug:  860542 ,  867556 
Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa
Reviewed-on: https://chromium-review.googlesource.com/1150683
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#579038}(cherry picked from commit e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469)
Reviewed-on: https://chromium-review.googlesource.com/1156766
Cr-Commit-Position: refs/branch-heads/3497@{#291}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/public/web/web_form_control_element.h
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/exported/web_form_control_element.cc
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/html/forms/text_control_element.h

Sign in to add a comment