Currently we misuse GetCachePath to check if code caching is enabled. Fix this by having a better API.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b8de0d33832d1f7c2b50de1f08b79d84d586d45 commit 0b8de0d33832d1f7c2b50de1f08b79d84d586d45 Author: Mythri Alle <mythria@chromium.org> Date: Mon Oct 22 11:06:22 2018 Add support so embedder can configure code cache settings. Add support that lets embedder specify if code caching is enabled and if enabled the disk size that can be used by the cache. By default code caching is disabled. This cl also adds implementation for chrome that enables code caching. Bug: chromium:867552 Change-Id: I6edb4c0c4f3830d44731225ec91c5e95005be9da Reviewed-on: https://chromium-review.googlesource.com/c/1213093 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601524} [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/android_webview/browser/aw_browser_context.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/android_webview/browser/aw_content_browser_client.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/browser/storage_partition_impl.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/browser/storage_partition_impl_unittest.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/public/browser/BUILD.gn [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/public/browser/content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/public/browser/content_browser_client.h [add] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/public/browser/generated_code_cache_settings.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/test/test_content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/content/test/test_content_browser_client.h [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/headless/lib/browser/headless_content_browser_client.cc [modify] https://crrev.com/0b8de0d33832d1f7c2b50de1f08b79d84d586d45/headless/lib/browser/headless_content_browser_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13842dda1db289585446a11505887db78560ff9d commit 13842dda1db289585446a11505887db78560ff9d Author: Mythri Alle <mythria@chromium.org> Date: Mon Nov 12 14:04:36 2018 Remove GetCachePath from BrowserContext. We used to use GetCachePath as a means to control the parameters of the code caching. To disable code caching embedder returned an empty path. Now, we replaced this with a better interface with GeneratedCodeCacheSettings [cl]. We no longer need GetCachePath interface for BrowserContext [cl]: https://chromium-review.googlesource.com/c/chromium/src/+/1213093 BUG: chromium:867552 Change-Id: Ifc7993548fa73d8713b935a7cb8cc5876ff3d431 Reviewed-on: https://chromium-review.googlesource.com/c/1301973 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607214} [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/android_webview/browser/aw_browser_context.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/browser/cached_image_fetcher/cached_image_fetcher_service_factory.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/browser/profiles/off_the_record_profile_impl.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/browser/profiles/off_the_record_profile_impl.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/browser/profiles/profile_impl.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/test/base/testing_profile.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chrome/test/base/testing_profile.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chromecast/browser/cast_browser_context.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/chromecast/browser/cast_browser_context.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/content/public/browser/browser_context.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/content/public/test/test_browser_context.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/content/public/test/test_browser_context.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/content/shell/browser/shell_browser_context.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/content/shell/browser/shell_browser_context.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/extensions/shell/browser/shell_prefs_unittest.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/headless/lib/browser/headless_browser_context_impl.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/headless/lib/browser/headless_browser_context_impl.h [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/webrunner/browser/webrunner_browser_context.cc [modify] https://crrev.com/13842dda1db289585446a11505887db78560ff9d/webrunner/browser/webrunner_browser_context.h
Comment 1 by mythria@chromium.org
, Jul 25