New issue
Advanced search Search tips

Issue 867550 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable DiskUtilTests.ZoneIdentifierWhenProcessIsRunning

Project Member Reported by joenotcharles@chromium.org, Jul 25

Issue description

chrome_cleaner's DiskUtilTests.ZoneIdentifierWhenProcessIsRunning fails with component builds because it involves copying test_process.exe before running it, and in a component build the copy does not include the component DLLs so the exe will not start.
 
Labels: SafeBrowsing-Triaged
The ZoneIdentifierWhenProcessIsRunning test starts test_process.exe with the chrome_cleaner::kTestForceOverwriteZoneIdentifier flag, which causes test_process.exe to overwrite its own zone identifier. Then the test verifies that it can remove the zone identifier while test_process.exe is still running.

I think the solution is to write a simple exe that doesn't use any chromium libraries and just loops forever. Then the test can:

- copy the exe to a temp dir
- write the zone identifier on the exe
- launch the exe
- remove the zone id from the exe, test for success
- slay the exe
Owner: ydago@chromium.org
The code for test_process.exe is here: https://cs.chromium.org/chromium/src/chrome/chrome_cleaner/test/test_process_main.cc
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Owner: joenotcharles@google.com

Sign in to add a comment