Prompt when user replies "lgtm" but withholds Code-Review +1 |
|||||
Issue descriptionI often type out "lgtm" but forget to click the +1 button (this habit is from Rietveld, which IIRC automatically granted +1 when the message contained "lgtm" and not "not lgtm"). It would be nice if, when I try to send a reply that includes "lgtm" (and not "not lgtm"), a warning box showed up to check whether I had forgotten to +1 the CL. I know Gerrit sometimes adds +1 when "lgtm" is typed, but this doesn't always trigger. This feature request is prompted by a CL where the reviewer sent an "lgtm" message but forgot the +1. The reviewer replied again later, saying "I forgot the +1 last time around"... and *still* forgot the +1! [1] [1] https://chromium-review.googlesource.com/c/chromium/src/+/1138319#message-4bbb7a91692dbefb0b466c58e4c59f24306ed690
,
Jul 25
This terminology is pretty google-specific. There's a plugin that's supposed to implement this on the chromium side, bouncing it to there.
,
Jul 25
,
Sep 19
,
Oct 31
Yeah, there is some basic functionality to apply the label when the user LGTMs a CL typing, but it has to be in the first line and there are some other checks. https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html#491 It could be improved.
,
Jan 11
Setting defect without priority to Pri-2. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted