New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix Compositing.SurfaceAggregator.LatestInFlightSurface.ManhattanDistanceToPrimary

Project Member Reported by akaba@google.com, Jul 25

Issue description

Compositing.SurfaceAggregator.LatestInFlightSurface.ManhattanDistanceToPrimary data is not showing because of extra line in the name in histogram.xml file.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b5dc1659e61ad62aa327506c5be30c9d49df10b

commit 5b5dc1659e61ad62aa327506c5be30c9d49df10b
Author: akaba <akaba@google.com>
Date: Wed Jul 25 20:31:47 2018

Fix Compositing.SurfaceAggregator.LatestInFlightSurface.ManhattanDistanceToPrimary

This CL remove the extra line in histogram.xml that's preventing the UMA from working.

In addition, we rename "Compositing.SurfaceManager.TemporarySurfaces" to
"Compositing.SurfaceManager.TemporaryReferences" as the data is actually counting
references not surfaces.

Bug:  867534 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7c4e4fc1a399d7e0d5fd8c6cea6a166f0ffbba76
Reviewed-on: https://chromium-review.googlesource.com/1150419
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578041}
[modify] https://crrev.com/5b5dc1659e61ad62aa327506c5be30c9d49df10b/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/5b5dc1659e61ad62aa327506c5be30c9d49df10b/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment