SurfaceRange::IsInRangeExclusive should consider the case when start and end have different embed tokens. |
||||
Issue descriptionCurrently, IsInRangeExclusive only works when start and end have the same embed token. But we want to have at least one of them match's |surface_id|'s embed_token instead.
,
Jul 25
,
Jul 25
IsInRangeExclusive is mainly going to be used in GetLatestInFlightSurface. Which allows the embed token of start and end to differ but the output could match at least one of them. This behavior is not implemented in the current version of IsInRangeExclusive.
,
Jul 31
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84109317ad1c478becd0d549f724a51cc1b8b727 commit 84109317ad1c478becd0d549f724a51cc1b8b727 Author: akaba <akaba@google.com> Date: Thu Aug 02 20:53:43 2018 Add utility methods to SurfaceRange & Fix SurfaceRange::IsInRangeExclusive This CL fixes SurfaceRange::IsInRangeExclusive in the case when the embed tokens are different by comparing with either ends of the range. In addition, it adds 2 extra utility functions to SurfaceRange which are needed to make the code cleaner for following work. Bug: 867531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia542e94b13c566989f3764c32cad4016bfddd32b Reviewed-on: https://chromium-review.googlesource.com/1159100 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580313} [modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range.cc [modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range.h [modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range_unittest.cc
,
Aug 2
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fsam...@chromium.org
, Jul 25