New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867531 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SurfaceRange::IsInRangeExclusive should consider the case when start and end have different embed tokens.

Project Member Reported by akaba@google.com, Jul 25

Issue description

Currently, IsInRangeExclusive only works when start and end have the same embed token. But we want to have at least one of them match's |surface_id|'s embed_token instead.
 
Then I don't know what "IsInRangeExclusive" is doing heh. I think it'll be hard to explain what it's doing and I'm not sure if it's generic enough to be on SurfaceRange then.
Owner: akaba@google.com
IsInRangeExclusive is mainly going to be used in GetLatestInFlightSurface. Which allows the embed token of start and end to differ but the output could match at least one of them. This behavior is not implemented in the current version of IsInRangeExclusive.
Owner: akaba@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84109317ad1c478becd0d549f724a51cc1b8b727

commit 84109317ad1c478becd0d549f724a51cc1b8b727
Author: akaba <akaba@google.com>
Date: Thu Aug 02 20:53:43 2018

Add utility methods to SurfaceRange & Fix SurfaceRange::IsInRangeExclusive

This CL fixes SurfaceRange::IsInRangeExclusive in the case when the embed
tokens are different by comparing with either ends of the range.
In addition, it adds 2 extra utility functions to SurfaceRange which are needed
to make the code cleaner for following work.

Bug:  867531 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia542e94b13c566989f3764c32cad4016bfddd32b
Reviewed-on: https://chromium-review.googlesource.com/1159100
Commit-Queue: Andre Kaba <akaba@google.com>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580313}
[modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range.cc
[modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range.h
[modify] https://crrev.com/84109317ad1c478becd0d549f724a51cc1b8b727/components/viz/common/surfaces/surface_range_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment