New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 852880



Sign in to add a comment

[📍] "can't find the isolate hash" with "test a patch" button

Project Member Reported by dtu@chromium.org, Jul 25

Issue description

Saw two jobs failing today with this error:
https://pinpoint-dot-chromeperf.appspot.com/job/166e2f6da40000
https://pinpoint-dot-chromeperf.appspot.com/job/14746665a40000

The "test a patch" button on the Pinpoint job page copies the current job's configuration to a perf try job on HEAD. But since the build target name was changed from "telemetry_perf_tests" to "performance_test_suite", the configuration from the original job isn't valid at HEAD.
 
Blocking: 852880
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f64f7ecb71d63982395a15bcd865ddc27d9b0ca4

commit f64f7ecb71d63982395a15bcd865ddc27d9b0ca4
Author: Dave Tu <dtu@chromium.org>
Date: Wed Jul 25 21:58:04 2018

[pinpoint] Hack to use performance_test_suite for patch jobs.

The "test a patch" button on the Pinpoint job page copies the current
job's configuration to a perf try job on HEAD. But since the build
target name was changed from "telemetry_perf_tests" to
"performance_test_suite", the configuration from the original job
isn't valid at HEAD.

Bug:  chromium:867521 
Change-Id: Ie6a8cac15aece07cd524dd427e6508691750be7b
Reviewed-on: https://chromium-review.googlesource.com/1150688
Commit-Queue: David Tu <dtu@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/f64f7ecb71d63982395a15bcd865ddc27d9b0ca4/dashboard/dashboard/pinpoint/elements/job-page/patch-job-fab.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab37f355f00d71bc26a5d56622b457f7c63ffa2

commit 3ab37f355f00d71bc26a5d56622b457f7c63ffa2
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 25 23:30:54 2018

Roll src/third_party/catapult c7d74cd68934..c829a63538ba (3 commits)

https://chromium.googlesource.com/catapult.git/+log/c7d74cd68934..c829a63538ba


git log c7d74cd68934..c829a63538ba --date=short --no-merges --format='%ad %ae %s'
2018-07-25 benjhayden@chromium.org Add API support for the new ReportTemplate system.
2018-07-25 dtu@chromium.org [pinpoint] Hack to use performance_test_suite for patch jobs.
2018-07-25 benjhayden@chromium.org Allow anonymous /api/test_suites requests.


Created with:
  gclient setdep -r src/third_party/catapult@c829a63538ba

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:867521 
TBR=sullivan@chromium.org

Change-Id: I0350fffd262ed295aaae1a1c71c662cdbc7d249c
Reviewed-on: https://chromium-review.googlesource.com/1150365
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578124}
[modify] https://crrev.com/3ab37f355f00d71bc26a5d56622b457f7c63ffa2/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment