New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867520 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 584384
issue 860420
issue 867536



Sign in to add a comment

Win debug builders are failing compiling media_unittests on GPU FYI wafterfalls

Project Member Reported by zmo@chromium.org, Jul 25

Issue description

[1799/2211] LINK media_unittests.exe media_unittests.exe.pdb
FAILED: media_unittests.exe media_unittests.exe.pdb 
ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./media_unittests.exe /PDB:./media_unittests.exe.pdb @./media_unittests.exe.rsp
../../third_party/llvm-build/Release+Asserts/bin\lld-link.exe: error: undefined symbol: ??1AnalysisResult@BitstreamConverter@mp4@media@@QEAA@XZ
>>> referenced by obj/media/filters/unit_tests/ffmpeg_demuxer_unittest.obj:(?ValidateAnnexB@media@@YAXPEAVDemuxerStream@1@W4Status@21@V?$scoped_refptr@VDecoderBuffer@media@@@@@Z)
../../third_party/llvm-build/Release+Asserts/bin\lld-link.exe: error: undefined symbol: ??0AnalysisResult@BitstreamConverter@mp4@media@@QEAA@XZ
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ParseCorrectly_Test@mp4@media@@UEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_StringConversionFunctions_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ValidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InvalidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InsertParamSetsAnnexB_Test@mp4@media@@EEAAXXZ)
../../third_party/llvm-build/Release+Asserts/bin\lld-link.exe: error: undefined symbol: ??1AnalysisResult@BitstreamConverter@mp4@media@@QEAA@XZ
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ParseCorrectly_Test@mp4@media@@UEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ParseCorrectly_Test@mp4@media@@UEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_StringConversionFunctions_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_StringConversionFunctions_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ValidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_ValidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InvalidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InvalidAnnexBConstructs_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InsertParamSetsAnnexB_Test@mp4@media@@EEAAXXZ)
>>> referenced by obj/media/formats/unit_tests/avc_unittest.obj:(?TestBody@AVCConversionTest_InsertParamSetsAnnexB_Test@mp4@media@@EEAAXXZ)
[1800/2211] LINK(DLL) accessibility.dll accessibility.dll.lib accessibility.dll.pdb
GPU Win debug builders have the following gn args:

ffmpeg_branding = "Chrome"
proprietary_codecs = true

If I just comment them out, then compile succeeds
Cc: wolenetz@chromium.org
There are two issues

1) https://chromium-review.googlesource.com/c/chromium/src/+/1144456 caused this link failure, so it needs to be reverted

2) why other win debug builders don't have the above two gn args?
In order to revert the culprit CL, https://chromium-review.googlesource.com/c/chromium/src/+/1149153 also needs to be reverted.
Blocking: 584384 860420
Cc: -wolenetz@chromium.org
Owner: wolenetz@chromium.org
Status: Fixed (was: Untriaged)
Both related CLs are reverted. Locally I confirmed that should fix the link failure.
OK I'll take a look at how to reland fixed version of #3.1, then #4.  I'll track in the original bugs (860420 and 584384).
Blocking: 867536
Cc: wolenetz@chromium.org sande...@chromium.org servolk@chromium.org
 Issue 867495  has been merged into this issue.
Fix of the link failure is included in the reland CL, currently in CQ: https://chromium-review.googlesource.com/c/chromium/src/+/1150247

Sign in to add a comment