New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867514 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Duplicate Tricium comments in fuchsia tool repo

Project Member Reported by juliehockett@google.com, Jul 25

Issue description

In https://fuchsia-review.googlesource.com/c/tools/+/175949, the spellchecker works and is posting comments, but it appears to be posting them twice. It also is posting them on code, which isn't particularly useful as we often use nonsense words as names.
 
It looks like the reason for the double-posting is that tricium-dev and tricium-prod are both posting to Gerrit; this is happening in the tools repo because the tools repo entry in tricium-dev.cfg doesn't have disable_reporting: true.


The suggestion to check spelling only in comments is worth considering.

However, I argue there's also reason to check non-comments, since we might also want to catch possible misspellings in strings and possibly also variable names; also, it only flags things that *look like* misspellings, so it doesn't flag "preProc" or "ctx"; but it flags "pres" because it looks like a possible misspelling.
I see the logic, but particularly in languages like Go the convention is to use highly abbreviated names, which would be caught by the spell checker like this. It just seems like unnecessary noise that will annoy developers, not help them.
Status: Available (was: Untriaged)
Summary: Duplicate Tricium comments in fuchsia tool repo (was: Spell checker analyzer comments on code, and comments are not being merged)
Yeah, we definitely don't want to make unnecessary noise that will annoy developers. Filed separate  bug 867538  for that issue.
Status: Fixed (was: Available)

Sign in to add a comment