chromedriver_py_tests fullscreen test is flaky/broken |
||||
Issue descriptionThis test is infrequently flaky on swarming in the Cocoa browser, usually fails on swarming in the MacViews browser, and doesn't fail locally in MacViews. I suspect that the reason is this code, in ChromeDesktopImpl::SetWindowBounds(): base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100)); Since there is an animation when fullscreening a window on Mac, this seems like a recipe for flake. I will disable this test on the bots.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3de1818c1091377cac372fa548bf3dd93f5ab9d3 commit 3de1818c1091377cac372fa548bf3dd93f5ab9d3 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Jul 25 17:36:36 2018 chromedriver: disable testWindowMaximize on bots Bug: 867511 Change-Id: I893a4d7b56d0ba4a14f54bb2fa59c33b51283316 Reviewed-on: https://chromium-review.googlesource.com/1150097 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577963} [modify] https://crrev.com/3de1818c1091377cac372fa548bf3dd93f5ab9d3/chrome/test/chromedriver/test/run_py_tests.py
,
Aug 2
,
Nov 19
***UI Mass Triage *** Since there is already a CL committed, hope the issue is fixed. Feel free to reopen if needed.
,
Nov 19
It is not. |
||||
►
Sign in to add a comment |
||||
Comment 1 by johnchen@chromium.org
, Jul 25