New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 867489
issue 888176
issue 889104



Sign in to add a comment

Explore Sites client

Project Member Reported by dewittj@chromium.org, Jul 25

Issue description

Tracking bug for client side work of Explore Sites.

This will be done in parallel to the UX prototype so that we can continue to test with users.  See also Issue 852075.

DD: go/explore-sites-client-design


 
Blockedon: 867489
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be6d244128ee8bef0e51fc9a86af2c218def2b5

commit 4be6d244128ee8bef0e51fc9a86af2c218def2b5
Author: Cathy Li <chili@chromium.org>
Date: Thu Aug 09 02:20:05 2018

[Explore sites]: Rename files for experimental explore sites to contain Experimental prefix

Bug:  867488 
Change-Id: Id45577a66f505af903e77c6bcc4771eab9e12e9c
Reviewed-on: https://chromium-review.googlesource.com/1161091
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581764}
[rename] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/res/layout/experimental_explore_sites_category_tile_view.xml
[rename] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/res/layout/experimental_explore_sites_section.xml
[modify] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/res/values-v17/styles.xml
[rename] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExperimentalExploreSitesCategoryTileView.java
[rename] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExperimentalExploreSitesSection.java
[modify] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/4be6d244128ee8bef0e51fc9a86af2c218def2b5/chrome/android/java_sources.gni

Components: -UI>Browser>Mobile UI>Browser>NewTabPage>ExploreSites
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd

commit 3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd
Author: Cathy Li <chili@chromium.org>
Date: Mon Aug 20 08:53:20 2018

[Explore sites]: Add native page frame for explore sites page.

Bug:  867488 
Change-Id: I886f26467826aa4c2beda38785bd4961f375e338
Reviewed-on: https://chromium-review.googlesource.com/1174699
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584382}
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/res/layout/experimental_explore_sites_section.xml
[add] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/res/layout/explore_sites_main.xml
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
[add] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/android/java_sources.gni
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/3f75eb2408c9d6701b493a4ff6f5067d8ea3e5fd/chrome/common/webui_url_constants.h

Labels: -Type-Bug Type-Task
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267e8d10b59c1af59f3d7a8e50b0144e0d213f18

commit 267e8d10b59c1af59f3d7a8e50b0144e0d213f18
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Aug 24 18:29:25 2018

[Explore Sites] Adds a store to contain the web catalog.

This adds a directory "Explore" in the profile directory
that contains the database files.  The DB is self-closing
after a period of time.

Bug:  867488 

Change-Id: I8ede0072853617b4f0be0a14cc9101c868898713
Reviewed-on: https://chromium-review.googlesource.com/1182308
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585911}
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/BUILD.gn
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_service_factory.cc
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[add] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_store.cc
[add] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_store.h
[add] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/browser/android/explore_sites/explore_sites_store_unittest.cc
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/chrome/test/BUILD.gn
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/267e8d10b59c1af59f3d7a8e50b0144e0d213f18/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 29

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ced61db5b5d3ead136d9de8f05389a37ba28beb

commit 5ced61db5b5d3ead136d9de8f05389a37ba28beb
Author: Cathy Li <chili@chromium.org>
Date: Thu Aug 30 09:31:00 2018

[Explore sites]: Create data classes and bridge method stubs for data loading.

Bug:  867488 
Change-Id: Ic6550d9f934d9d15e584b38efc0c877389fef1ac
Reviewed-on: https://chromium-review.googlesource.com/1185378
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587494}
[modify] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[add] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[add] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageLayout.java
[add] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSite.java
[modify] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/java_sources.gni
[add] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryUnitTest.java
[modify] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/5ced61db5b5d3ead136d9de8f05389a37ba28beb/chrome/browser/android/explore_sites/explore_sites_bridge.h

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c9da9a6c8043bec728014e6a231041f3c67bba

commit 21c9da9a6c8043bec728014e6a231041f3c67bba
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Sep 07 16:14:13 2018

[Explore Sites] Adds the catalog proto.

This is used on the wire from the Explore Sites API to Chrome.

Bug:  867488 
Change-Id: Id830f53b7ea7cfad8fbd6c7e38694d2de43ff558
Reviewed-on: https://chromium-review.googlesource.com/1210945
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589535}
[modify] https://crrev.com/21c9da9a6c8043bec728014e6a231041f3c67bba/chrome/browser/BUILD.gn
[add] https://crrev.com/21c9da9a6c8043bec728014e6a231041f3c67bba/chrome/browser/android/explore_sites/catalog.proto

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e02502b490a0ebfed24f775cf4eb54d6f002a566

commit e02502b490a0ebfed24f775cf4eb54d6f002a566
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Sep 11 17:51:09 2018

[EoS] Support for adding catalog proto to the store.

This adds an ImportCatalogTask that will take a proto directly from the
service API and add records to the database.  It has the following
behavior:
* If the timestamp matches the "current" version, it does nothing. This
  prevents stomping on the currently viewable catalog.
* If the timestamp matches the "downloading" version, it overwrites it,
  since that version is not yet viewable by the user.
* Sets the "downloading" version number to the input version timestamp.

Bug:  867488 
Change-Id: I1c1725a664f348eb5399da2d42d0d8c22c44e1c0
Reviewed-on: https://chromium-review.googlesource.com/1213707
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590384}
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/BUILD.gn
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_schema.cc
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_schema.h
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_store.cc
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/explore_sites_store.h
[add] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/import_catalog_task.cc
[add] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/import_catalog_task.h
[add] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/browser/android/explore_sites/import_catalog_task_unittest.cc
[modify] https://crrev.com/e02502b490a0ebfed24f775cf4eb54d6f002a566/chrome/test/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425b550ffb7f508e60175a72fa0b1ac84dfbfdef

commit 425b550ffb7f508e60175a72fa0b1ac84dfbfdef
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Sep 14 22:18:03 2018

[EoS] Add an ExploreSitesService API for getting the current catalog.

This is implemented by adding a GetCatalogTask that has a few jobs:
* Return the current catalog
* Update the current catalog if there is one in the DB and it's the
  first time the catalog was requested since Chrome started.

Also removes the "usable_on_ntp" boolean column from the sql store
as it doesn't have a clear use in the design doc.

Bug:  867488 
Change-Id: I17ff725633f13e57a542e7e48fcf974a1ae1a3d1
Reviewed-on: https://chromium-review.googlesource.com/1226193
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591495}
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/BUILD.gn
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_schema.cc
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[add] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_types.cc
[add] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/explore_sites_types.h
[add] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/get_catalog_task.cc
[add] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/get_catalog_task.h
[add] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/browser/android/explore_sites/import_catalog_task.cc
[modify] https://crrev.com/425b550ffb7f508e60175a72fa0b1ac84dfbfdef/chrome/test/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da

commit ac777bddac0a8e87485fc7b88eae79a6f5f0f0da
Author: Cathy Li <chili@chromium.org>
Date: Sat Sep 15 00:29:34 2018

Refactor out TileView to be common widget

This is to facilitate sharing between explore sites and most likely tiles.

Bug:  867488 
Change-Id: Ic84c2a5363318bea6e7237085d4df9f346b09891
Reviewed-on: https://chromium-review.googlesource.com/1213706
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591537}
[add] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/res/layout/suggestions_tile_view.xml
[add] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/res/layout/suggestions_tile_view_condensed.xml
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/res/layout/tile_view_modern.xml
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/res/layout/tile_view_modern_condensed.xml
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSectionViewHolder.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsConfig.java
[add] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsTileView.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridLayout.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridViewHolder.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java
[delete] https://crrev.com/953cf5faa50a81c7c92aa0f5e5ad9ae8bad5cac8/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileView.java
[add] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java/src/org/chromium/chrome/browser/widget/tile/TileWithTextView.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/java_sources.gni
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
[modify] https://crrev.com/ac777bddac0a8e87485fc7b88eae79a6f5f0f0da/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c04c52327a5c2941c2647de2a6c7ebb61934fd

commit d7c04c52327a5c2941c2647de2a6c7ebb61934fd
Author: Justin DeWitt <dewittj@chromium.org>
Date: Mon Sep 17 20:02:55 2018

[EoS] Connect ExploreSitesBridge to the ExploreSitesService

This actually calls ExploreSitesService::GetCatalog when the request
comes in from the bridge.  Also adds methods for converting the native
objects to Java.

Bug:  867488 
Change-Id: Ideee8134ca7947ad95423485655441c3b55d77a7
Reviewed-on: https://chromium-review.googlesource.com/1228312
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591795}
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSite.java
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryUnitTest.java
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/browser/BUILD.gn
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/d7c04c52327a5c2941c2647de2a6c7ebb61934fd/chrome/browser/android/explore_sites/explore_sites_bridge_experimental.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9771f0b969c556611414b26668bf69f9064ca4f

commit f9771f0b969c556611414b26668bf69f9064ca4f
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Sep 19 19:11:43 2018

[EoS] Add APIs and tasks related to pulling images from the data store.

This patch:
* Adds APIs to ExploreSitesService that can request either a site image
  or a category image (which is a composite of multiple site images) as
  an SkBitmap (which is the format required for Java Bitmaps).
* Adds a task to fetch one or more images from the ExploreSitesStore,
  based on the site ID or category ID.
* The task filters based on the existence of an entry in the
  site_blacklist table (which is not populated yet but will be as a
  result of user long-press.

This DOES NOT implement conversion from byte vectors to SkBitmap (left
as a TODO.)

Bug:  867488 
Change-Id: Id2e6a6abe2781b790f9ce3f597a9e747eddd4715
Reviewed-on: https://chromium-review.googlesource.com/1233176
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592501}
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/BUILD.gn
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/explore_sites_types.h
[add] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/get_images_task.cc
[add] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/get_images_task.h
[add] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/browser/android/explore_sites/get_images_task_unittest.cc
[modify] https://crrev.com/f9771f0b969c556611414b26668bf69f9064ca4f/chrome/test/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adba06f27df4ceb2207c1b3206f557fc038ce4d0

commit adba06f27df4ceb2207c1b3206f557fc038ce4d0
Author: Cathy Li <chili@chromium.org>
Date: Thu Sep 20 16:16:45 2018

[Explore sites]: Refactor navigation delegate to a more common location

mv ntp/ContextMenuManager.java to native_page/
mv suggestions/SuggestionsNavigationDelegate.java to native_page/NativePageNavigationDelegate.java and remove suggestions-only methods
cp suggestions/SuggestionsNavigationDelegateImpl.java to native_page/NativePageNavigationDelegateImpl.java and remove suggestions-only methods
have suggestions/SuggestionsNavigationDelegate.java extend native_page/NativePageNavigationDelegateImpl to contain suggestions-only methods
update all references thereof

Bug:  867488 
Change-Id: I64cb9bb6864da2a90b9358ec2a4f339d76df1cdc
Reviewed-on: https://chromium-review.googlesource.com/1232336
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592827}
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPageMediator.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContentCoordinator.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionCardViewHolder.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsAdapter.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCoordinator.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExperimentalExploreSitesSection.java
[rename] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/native_page/ContextMenuManager.java
[add] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageNavigationDelegate.java
[add] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/native_page/NativePageNavigationDelegateImpl.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PersonalizedPromoViewHolder.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegate.java
[delete] https://crrev.com/ee39cbec935c86d8f5db2e428168fa18f67cd9e6/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/java_sources.gni
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfoTest.java
[modify] https://crrev.com/adba06f27df4ceb2207c1b3206f557fc038ce4d0/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f2506db4ac77701eda8a7a0981dc58a4b0050e

commit 07f2506db4ac77701eda8a7a0981dc58a4b0050e
Author: Jonathan Freed <freedjm@chromium.org>
Date: Thu Sep 20 20:02:34 2018

[Explore Sites] Adding URL fetcher for Explore Sites.

This will be used to fetch the data from our API endpoint. It is only a fetcher
and does not do any processing of the data that is downloaded.

Bug:  867488 
Change-Id: Ic7506af2523632c1173333ddf2a1f2183b27f72f
Reviewed-on: https://chromium-review.googlesource.com/1229013
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592919}
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/BUILD.gn
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/catalog.proto
[add] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[add] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[add] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/explore_sites_types.h
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/ntp_json_fetcher.cc
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/url_util.cc
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/url_util.h
[add] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/url_util_experimental.cc
[add] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/browser/android/explore_sites/url_util_experimental.h
[modify] https://crrev.com/07f2506db4ac77701eda8a7a0981dc58a4b0050e/chrome/test/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c425234b9321b2ae306ef972fb23a6249f0cc584

commit c425234b9321b2ae306ef972fb23a6249f0cc584
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Sep 21 03:47:55 2018

[EoS] Implement background scheduler task for Explore Sites updates.

This implements a periodic background task that attempts to fetch the
Explore Sites catalog approximately daily.  Fetch implementation is left
to a future CL, as is initiating the background task.

Bug:  867488 
Change-Id: I808a7bacd9f20c3c1dbcaf84acd413eb7353c644
Reviewed-on: https://chromium-review.googlesource.com/1236506
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593071}
[add] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTask.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/chrome/android/java_sources.gni
[add] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTaskUnitTest.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerUma.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerUmaTest.java
[modify] https://crrev.com/c425234b9321b2ae306ef972fb23a6249f0cc584/tools/metrics/histograms/enums.xml

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab02919722bfc6297e7c1b49d3255bc578fbd994

commit ab02919722bfc6297e7c1b49d3255bc578fbd994
Author: Cathy Li <chili@chromium.org>
Date: Mon Sep 24 21:27:40 2018

[Explore sites]: Create category card recycler view.

Bug:  867488 
Change-Id: Ied05d87e4d1a104f4a6012d465fcf20fd85c3bcf
Reviewed-on: https://chromium-review.googlesource.com/1225935
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593689}
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/res/layout/explore_sites_category_card_view.xml
[delete] https://crrev.com/f3caad1d2d1bd81e69811cd2165e89c536294c60/chrome/android/java/res/layout/explore_sites_main.xml
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/res/layout/explore_sites_page_layout.xml
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/res/layout/explore_sites_tile_view.xml
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardAdapter.java
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardViewHolderFactory.java
[modify] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[add] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
[modify] https://crrev.com/ab02919722bfc6297e7c1b49d3255bc578fbd994/chrome/android/java_sources.gni

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfed5e52d8504cce98edd9f82b1e52893d2af51b

commit dfed5e52d8504cce98edd9f82b1e52893d2af51b
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Sep 25 02:54:54 2018

[EoS] Change version to a string, and update the protobufs to match

Version as integer timestamp has problems when considering  caching versions
that are actually filtered dynamically on the server, so we switch to
an opaque string version_token that the server can choose.

Client loses the ability to determine if a new version is "newer" or
"older" but this doesn't seem like much of a loss.

Bug:  867488 
Change-Id: I43fadaf2ccfecec8143f45473d1b863f38345cac
Reviewed-on: https://chromium-review.googlesource.com/1241531
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593807}
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/catalog.proto
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_schema.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_types.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/explore_sites_types.h
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/get_catalog_task.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/get_images_task_unittest.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/import_catalog_task.cc
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/import_catalog_task.h
[modify] https://crrev.com/dfed5e52d8504cce98edd9f82b1e52893d2af51b/chrome/browser/android/explore_sites/import_catalog_task_unittest.cc

Blockedon: 888176
Blockedon: 889104
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947bd6b7cd3957e8010a986bc2fb311c6e4f85bc

commit 947bd6b7cd3957e8010a986bc2fb311c6e4f85bc
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Sep 26 21:47:28 2018

[EoS] Fetcher fixes

When testing end-to-end, found some problems with the Fetcher:
* POST is not accepted by the server, converted to GET (using query
  params)
* URL was not set in the request
* URL utils had a bug causing "/v1/" to be missing from the path.

Bug:  867488 
Change-Id: Ie60010bc45ac67923d211bce2a84248186f2dbc0
Reviewed-on: https://chromium-review.googlesource.com/1247021
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594484}
[modify] https://crrev.com/947bd6b7cd3957e8010a986bc2fb311c6e4f85bc/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/947bd6b7cd3957e8010a986bc2fb311c6e4f85bc/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/947bd6b7cd3957e8010a986bc2fb311c6e4f85bc/chrome/browser/android/explore_sites/url_util.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341

commit 2c5b6347b6a17b07cd6ee380fa3e5e76399ed341
Author: Cathy Li <chili@chromium.org>
Date: Wed Sep 26 23:50:47 2018

[ExploreSites]: Connect all explore sites components together.

Does not load images yet. Also looks very ugly.

Bug:  867488 
Change-Id: I9acf386718bdd5aefdd1f87f0b31210fc61a102b
Reviewed-on: https://chromium-review.googlesource.com/1242295
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594528}
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/res/layout/explore_sites_category_card_view.xml
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/res/layout/explore_sites_page_layout.xml
[rename] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
[rename] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardViewHolderFactory.java
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
[modify] https://crrev.com/2c5b6347b6a17b07cd6ee380fa3e5e76399ed341/chrome/android/java_sources.gni

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05691904b6773f530a81f38da15b8f7e7c575d4f

commit 05691904b6773f530a81f38da15b8f7e7c575d4f
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Sep 27 15:15:19 2018

[EoS] Enable scheduling the daily catalog update task.

- The ExploreSitesService is configured to start on startup if the
  feature is enabled, and will schedule the daily task directly in the
  service factory.
- The task will cancel itself if it runs and the feature is disabled.

Bug:  867488 
Change-Id: I38b55c97d9b2d26a3c94cdff5bcce03bf341d404
Reviewed-on: https://chromium-review.googlesource.com/1244738
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594726}
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTask.java
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTaskUnitTest.java
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/browser/BUILD.gn
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[add] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/browser/android/explore_sites/explore_sites_bridge.h
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/browser/android/explore_sites/explore_sites_service_factory.cc
[modify] https://crrev.com/05691904b6773f530a81f38da15b8f7e7c575d4f/chrome/browser/android/explore_sites/explore_sites_service_factory.h

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250761c27c05459e3be66facbf2dfddd0b2339e8

commit 250761c27c05459e3be66facbf2dfddd0b2339e8
Author: Cathy Li <chili@chromium.org>
Date: Thu Sep 27 19:27:23 2018

[Explore sites]: Add context menu actions for explore sites

Context menu actions were added by https://chromium-review.googlesource.com/c/chromium/src/+/1242295

Bug:  867488 
Change-Id: I2a83800e985dd7b62402f049cf9b0707c04e0b7a
Reviewed-on: https://chromium-review.googlesource.com/1248126
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594812}
[modify] https://crrev.com/250761c27c05459e3be66facbf2dfddd0b2339e8/tools/metrics/actions/actions.xml

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/932101ae25b08d2528d93236620dde68a26edbe8

commit 932101ae25b08d2528d93236620dde68a26edbe8
Author: Justin DeWitt <dewittj@chromium.org>
Date: Mon Oct 01 19:48:34 2018

[EoS] Fix image decoding

This patch fixes a few issues found while trying to hook up image
decoding end-to-end:
* The images are improperly inserted into the database, since binding as
  string uses the text type, which tries to use UTF8 encoding (which
  doesn't work for binary blobs.)
* Decode failures used to cause a DCHECK, now just bail out with an
  error value
* A callback was called one too many times, even after std::move.
* A crash would happen if a category had no images.

Bug:  867488 
Change-Id: Ie28c01e28bd746b9a90563c228775ff3b5a8f83f
Reviewed-on: https://chromium-review.googlesource.com/1248041
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595514}
[modify] https://crrev.com/932101ae25b08d2528d93236620dde68a26edbe8/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/932101ae25b08d2528d93236620dde68a26edbe8/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/932101ae25b08d2528d93236620dde68a26edbe8/chrome/browser/android/explore_sites/import_catalog_task.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b

commit 2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b
Author: Dmitry Titov <dimich@chromium.org>
Date: Mon Oct 01 22:13:43 2018

Add GetMontlyHostCount() stat counting method to HistoryService.

This will be used in Explore Sites to track breadth of web usage.
It'll be called from ExplreSitesService, on a schedule, approximately once a week.

Bug:  867488 
Change-Id: If535dfead7f11dbaf501472dc42eaa882cbd94c4
Reviewed-on: https://chromium-review.googlesource.com/1248128
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595572}
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_backend.h
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_database.cc
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_database.h
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_service.cc
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_service.h
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_service_unittest.cc
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/components/history/core/browser/history_types.h
[modify] https://crrev.com/2ebd4b9d24cd15f89223fd5a9e587d0a1273ca2b/tools/metrics/histograms/histograms.xml

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a008c590370f9e0549907ba5d79ae157598432be

commit a008c590370f9e0549907ba5d79ae157598432be
Author: Justin DeWitt <dewittj@chromium.org>
Date: Mon Oct 01 22:33:28 2018

[EoS] Adds requests for category images.

* If no catalog is present, requests one from the network and displays
  default images.  When request finishes, updates the category images.
* Updates category images right away if not requesting from the network.
* Fixes the query in GetCatalogTask so that if there is no "current"
  catalog, it will use the "downloading" catalog instead.

Bug:  867488 
Change-Id: Ic307f77a4b3ae2ededa711f619059b1aed562012
Reviewed-on: https://chromium-review.googlesource.com/1252908
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595605}
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryUnitTest.java
[modify] https://crrev.com/a008c590370f9e0549907ba5d79ae157598432be/chrome/browser/android/explore_sites/explore_sites_bridge.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b13dfd330625d838904634078a0f1b31ea6335

commit 20b13dfd330625d838904634078a0f1b31ea6335
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Oct 02 21:06:23 2018

[EoS] Add country code to the request for the catalog.

The country code comes from the first place in the following list with a
non-empty country code:
* Field Trial parameter "country_override", configurable by Finch server
* Finch permanent country, which is updated when the Finch configs are
  updated (by default once per Chrome version). Permanent country may
  not be available in the first run of Chrome.
* Finch latest country, which is available on every run of Chrome.

Bug:  867488 
Change-Id: I0e407a50a4020882152dda85935ecf843a000cb0
Reviewed-on: https://chromium-review.googlesource.com/c/1256110
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595978}
[modify] https://crrev.com/20b13dfd330625d838904634078a0f1b31ea6335/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/20b13dfd330625d838904634078a0f1b31ea6335/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[modify] https://crrev.com/20b13dfd330625d838904634078a0f1b31ea6335/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/20b13dfd330625d838904634078a0f1b31ea6335/chrome/browser/android/explore_sites/explore_sites_service_impl.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a5a3829963cf49fec2a6287c5fab5bcba242a3

commit f8a5a3829963cf49fec2a6287c5fab5bcba242a3
Author: Cathy Li <chili@chromium.org>
Date: Wed Oct 03 23:47:03 2018

[Explore sites]: Add error and loading from network views to recycler view.

Bug:  867488 
Change-Id: Ic2615ce1b19eaf9fb283890d1a25df124b26fce2
Reviewed-on: https://chromium-review.googlesource.com/c/1252849
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596429}
[add] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/res/layout/explore_sites_loading_error_view.xml
[add] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/res/layout/explore_sites_loading_from_net_view.xml
[modify] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
[modify] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardViewHolderFactory.java
[modify] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/f8a5a3829963cf49fec2a6287c5fab5bcba242a3/chrome/android/java/strings/android_chrome_strings.grd

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6cfb4f79a269aef834c240d542ec15c26799d6

commit 5f6cfb4f79a269aef834c240d542ec15c26799d6
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Oct 05 18:52:14 2018

Add HistoryStatisticsReporter for upcoming ExploreSites feature.

It should compute and report monthly visited host count approximatley every week.
It also only runs once per Chrome session and after a delay to avoid slowing down startup.
The average cost of computation is less than 10ms and most of it is on background thread, however
this is still enough to implement 'sparse' way of querying.

Bug:  867488 
Change-Id: I000ef4224f87d4d98c0a73519ce9648feb158df7
Reviewed-on: https://chromium-review.googlesource.com/c/1260494
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597217}
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/BUILD.gn
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/explore_sites_service_factory.cc
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[add] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/history_statistics_reporter.cc
[add] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/history_statistics_reporter.h
[add] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/android/explore_sites/history_statistics_reporter_unittest.cc
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/chrome/test/BUILD.gn
[modify] https://crrev.com/5f6cfb4f79a269aef834c240d542ec15c26799d6/tools/metrics/histograms/histograms.xml

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec708e3ccd86d1d84bb5f11e33cfc761f4055214

commit ec708e3ccd86d1d84bb5f11e33cfc761f4055214
Author: Jian Li <jianli@chromium.org>
Date: Fri Oct 05 19:15:50 2018

[EoS] Add backoff support EoS url fetcher

Also make EoS url fetcher support immediate or background fetch with
different backoff policy.

Bug:  867488 
Change-Id: If41abed1f85781cf84b9038f600e0a94c6c1524c
Reviewed-on: https://chromium-review.googlesource.com/c/1263053
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597231}
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTask.java
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTaskUnitTest.java
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[modify] https://crrev.com/ec708e3ccd86d1d84bb5f11e33cfc761f4055214/chrome/browser/android/explore_sites/explore_sites_types.h

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad391c1e711c11626caa3fd56042826b417ce716

commit ad391c1e711c11626caa3fd56042826b417ce716
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Oct 05 21:11:02 2018

Update description of History.MonthlyHostCount to include ref to a similar metric.

The new metric ExploreSites.MonthlyHostCount counts the same thing but is reported
on elapsed-time basis instead of on on-startup basis to help avoid bias toward
more active users who start Chrome more often.
Also updated 'units' for related histograms.

Bug:  867488 
Change-Id: I22915ed143af031dadb74aaee5d9b6260726f1af
Reviewed-on: https://chromium-review.googlesource.com/c/1265496
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597294}
[modify] https://crrev.com/ad391c1e711c11626caa3fd56042826b417ce716/tools/metrics/histograms/histograms.xml

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37e6d817705e4d2e0bf79f8556b5eea87d3792e3

commit 37e6d817705e4d2e0bf79f8556b5eea87d3792e3
Author: Dmitry Titov <dimich@chromium.org>
Date: Mon Oct 08 21:24:37 2018

Record UMA metrics for initial experiment with ExploreSites.

- Add Android.ExploreSitespage.Open User Action
- Add ExploreSites.ClickedNTPCategoryIndex histogram

Bug:  867488 
Change-Id: I389c688cc2ef73e80c26499a6122f52cbcc5aee6
Reviewed-on: https://chromium-review.googlesource.com/c/1266096
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597684}
[modify] https://crrev.com/37e6d817705e4d2e0bf79f8556b5eea87d3792e3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/37e6d817705e4d2e0bf79f8556b5eea87d3792e3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/37e6d817705e4d2e0bf79f8556b5eea87d3792e3/tools/metrics/actions/actions.xml
[modify] https://crrev.com/37e6d817705e4d2e0bf79f8556b5eea87d3792e3/tools/metrics/histograms/histograms.xml

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e761be3f987ff31d3d9c298993e38e58c3775d82

commit e761be3f987ff31d3d9c298993e38e58c3775d82
Author: Cathy Li <chili@chromium.org>
Date: Mon Oct 08 21:32:31 2018

[Explore sites]: Add icon fetching to category card

Bug:  867488 
Change-Id: Iafff56a245049812bc0f941413847b1a68540ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1261775
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597686}
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSite.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/java/src/org/chromium/chrome/browser/widget/tile/TileWithTextView.java
[modify] https://crrev.com/e761be3f987ff31d3d9c298993e38e58c3775d82/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryUnitTest.java

Project Member

Comment 38 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52d10b332bfeda606ae9d1fea34e7dca269c3ee2

commit 52d10b332bfeda606ae9d1fea34e7dca269c3ee2
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue Oct 09 00:57:34 2018

Add UMA for ExploreSites NTP section - opening and loading.

Adds Android.ExploreSitesNTP.Opened user action and
ExploreSites.NTPLoadingCatalogFromNetwork histogram to record if the local catalog
was used or we had to initiate network request to fetch one.

Bug:  867488 
Change-Id: Ie5c3593c902dd20594bce9a982ef4b5b9573d449
Reviewed-on: https://chromium-review.googlesource.com/c/1269443
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597760}
[modify] https://crrev.com/52d10b332bfeda606ae9d1fea34e7dca269c3ee2/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/52d10b332bfeda606ae9d1fea34e7dca269c3ee2/tools/metrics/actions/actions.xml
[modify] https://crrev.com/52d10b332bfeda606ae9d1fea34e7dca269c3ee2/tools/metrics/histograms/histograms.xml

Project Member

Comment 40 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/014d10f356967fa17ef7edc0947a703abc611fc7

commit 014d10f356967fa17ef7edc0947a703abc611fc7
Author: Cathy Li <chili@chromium.org>
Date: Tue Oct 09 19:26:49 2018

[Explore sites]: Fetch catalog from ESP

Bug:  867488 
Change-Id: I973b8799af25f98895c8c870a39bea67e26c9506
Reviewed-on: https://chromium-review.googlesource.com/c/1270001
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598037}
[modify] https://crrev.com/014d10f356967fa17ef7edc0947a703abc611fc7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java

Project Member

Comment 41 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82582e03eca63741c66de3aa13aab940bf3f9aa

commit f82582e03eca63741c66de3aa13aab940bf3f9aa
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Oct 09 23:06:01 2018

[EoS] Add fade animations to the NTP

There is a nontrivial delay before icons pop into being, so fade them in.
The animations cover 3 cases:
* No catalog exists, just immediately render the vector default assets
* Catalog exists locally, fade in the category tiles
* Catalog exists remotely, render vector assets then replace with
  category tiles using a fade-out fade-in animation.

Bug:  867488 
Change-Id: I958e1e8e3ef88c1dad86869a8e1812e432952989
Reviewed-on: https://chromium-review.googlesource.com/c/1272087
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598122}
[modify] https://crrev.com/f82582e03eca63741c66de3aa13aab940bf3f9aa/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/f82582e03eca63741c66de3aa13aab940bf3f9aa/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711470b636e844fc71f45f249d039f1e21ff4fe5

commit 711470b636e844fc71f45f249d039f1e21ff4fe5
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Oct 10 15:46:52 2018

[EoS] Fix the black background

This takes the simple approach of setting a background color for the
Explore Sites recycler view.

Bug:  867488 
Change-Id: I107b6365240ea4e2af6401ca7329c7fa8601e436
Reviewed-on: https://chromium-review.googlesource.com/c/1272299
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598341}
[modify] https://crrev.com/711470b636e844fc71f45f249d039f1e21ff4fe5/chrome/android/java/res/layout/explore_sites_page_layout.xml

Project Member

Comment 44 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ba967bd6fde79cc8a46a7acf07ea28259650a6

commit 85ba967bd6fde79cc8a46a7acf07ea28259650a6
Author: Dmitry Titov <dimich@chromium.org>
Date: Thu Oct 11 21:30:49 2018

Fix for number of buckets for a ExploreSites.ClickedNTPCategoryIndex histogram.
The number of buckets should be one more than max value.

Bug:  867488 
Change-Id: I7bf31a910826d8cd4f2f82de8da9f941cad33d4d
Reviewed-on: https://chromium-review.googlesource.com/c/1277833
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598954}
[modify] https://crrev.com/85ba967bd6fde79cc8a46a7acf07ea28259650a6/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java

Project Member

Comment 45 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef68cce2796013e39a184333fc9adc4940ce24a

commit bef68cce2796013e39a184333fc9adc4940ce24a
Author: Cathy Li <chili@chromium.org>
Date: Thu Oct 11 21:31:32 2018

[Explore sites:] Fix recycler crash when loading from network.

Bug:  894586 ,  867488 
Change-Id: I1f20cbf976bdb0a6507cc065317fa5f3f354f228
Reviewed-on: https://chromium-review.googlesource.com/c/1277829
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598955}
[modify] https://crrev.com/bef68cce2796013e39a184333fc9adc4940ce24a/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java

Project Member

Comment 46 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2d4f3e39d0af7a283b748040cceb089de4fb172

commit c2d4f3e39d0af7a283b748040cceb089de4fb172
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Oct 12 00:16:27 2018

Replace sparse histogram with a linear one. This avoids extra lock on reporting.

Bug:  867488 
Change-Id: If8b99bc2e5c4636ed42d5e68d9e08dc099e8bb27
Reviewed-on: https://chromium-review.googlesource.com/c/1277818
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599031}
[modify] https://crrev.com/c2d4f3e39d0af7a283b748040cceb089de4fb172/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java

Project Member

Comment 47 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f

commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f
Author: Cathy Li <chili@chromium.org>
Date: Fri Oct 12 20:45:57 2018

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599339}
[modify] https://crrev.com/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f/chrome/android/java/res/values/dimens.xml

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 15

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87455017b2733f06e5d98c25ab0799e78488f1e9

commit 87455017b2733f06e5d98c25ab0799e78488f1e9
Author: Cathy Li <chili@chromium.org>
Date: Mon Oct 15 17:23:50 2018

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599339}(cherry picked from commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f)
Reviewed-on: https://chromium-review.googlesource.com/c/1281048
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#23}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/87455017b2733f06e5d98c25ab0799e78488f1e9/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/87455017b2733f06e5d98c25ab0799e78488f1e9/chrome/android/java/res/values/dimens.xml

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/87455017b2733f06e5d98c25ab0799e78488f1e9

Commit: 87455017b2733f06e5d98c25ab0799e78488f1e9
Author: chili@chromium.org
Commiter: chili@chromium.org
Date: 2018-10-15 17:23:50 +0000 UTC

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599339}(cherry picked from commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f)
Reviewed-on: https://chromium-review.googlesource.com/c/1281048
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#23}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)

Sign in to add a comment