Laser pointer doesn't work when started in shortcut viewer |
||||||
Issue descriptionThis is likely related to when events are forwarded to remove clients.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78ca7f9dce3d8e346b54ff6aa0be00b268763740 commit 78ca7f9dce3d8e346b54ff6aa0be00b268763740 Author: Scott Violet <sky@chromium.org> Date: Thu Jul 26 21:08:49 2018 chromeos: makes ServerWindow install pre-target handler using kDefault Using kSystem means it conflicts with other system level landers, such as the laser pointer. BUG= 867483 TEST=covered by tests Change-Id: I40581e6ae8716e333d1e64ecd2ae8ebbcbf1936d Reviewed-on: https://chromium-review.googlesource.com/1151546 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578438} [modify] https://crrev.com/78ca7f9dce3d8e346b54ff6aa0be00b268763740/ash/laser/laser_pointer_controller_unittest.cc [modify] https://crrev.com/78ca7f9dce3d8e346b54ff6aa0be00b268763740/ash/test/ash_test_base.h [modify] https://crrev.com/78ca7f9dce3d8e346b54ff6aa0be00b268763740/services/ui/ws2/BUILD.gn [modify] https://crrev.com/78ca7f9dce3d8e346b54ff6aa0be00b268763740/services/ui/ws2/server_window.cc
,
Jul 30
Requesting a merge to 69 as without this laser pointer/magnifier is broke for the keyboard shortcut viewer.
,
Jul 30
,
Jul 31
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09730d01ef65869342b774337807b68f4bee72ee commit 09730d01ef65869342b774337807b68f4bee72ee Author: Scott Violet <sky@chromium.org> Date: Tue Jul 31 19:31:12 2018 MERGE: chromeos: makes ServerWindow install pre-target handler using kDefault Using kSystem means it conflicts with other system level landers, such as the laser pointer. BUG= 867483 TEST=covered by tests Change-Id: I40581e6ae8716e333d1e64ecd2ae8ebbcbf1936d Reviewed-on: https://chromium-review.googlesource.com/1151546 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578438}(cherry picked from commit 78ca7f9dce3d8e346b54ff6aa0be00b268763740) Reviewed-on: https://chromium-review.googlesource.com/1157039 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#289} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/09730d01ef65869342b774337807b68f4bee72ee/ash/laser/laser_pointer_controller_unittest.cc [modify] https://crrev.com/09730d01ef65869342b774337807b68f4bee72ee/ash/test/ash_test_base.h [modify] https://crrev.com/09730d01ef65869342b774337807b68f4bee72ee/services/ui/ws2/BUILD.gn [modify] https://crrev.com/09730d01ef65869342b774337807b68f4bee72ee/services/ui/ws2/server_window.cc
,
Jul 31
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sky@chromium.org
, Jul 26