New issue
Advanced search Search tips

Issue 867478 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

OOBE a11y: Magnifier + high contrast keyboard shortcuts don't work

Project Member Reported by leberly@chromium.org, Jul 25

Issue description

Google Chrome	69.0.3494.0 (Official Build) dev (64-bit)
Google Eve

Steps to repro:
# Powerwash to get to OOBE
# Note that ctrl + alt + z turns on ChromeVox as expected
# Try the following keyboard shortcuts: 
ctrl + search + d for docked magnifier
ctrl + search + m for fullscreen magnifier
ctrl + search + h for high contrast

Expected: keyboard shortcuts work especially since there is a precedent set with ChromeVox
Actual: shortcuts do nothing 

 
Cc: -katydek@google.com afakhry@chromium.org katie@chromium.org
Owner: sarakato@chromium.org
Status: Assigned (was: Available)
Sara, I think this is a dupe of issue 860093. If so, please merge it.


Hi Sara,

This bug occurs on the very first OOBE screen after you Powerwash while 860093 occurs on the login screen. If they have the same root cause, please go ahead and merge. In the other bug, if you do merge, please ask that the person who verifies checks both places once it's fixed. 

Thanks,

Laura 
fixing 860093 doesn't fix the issue, so I'll investigate further
is this the desired behavior ?
https://photos.app.goo.gl/yEYQRCKph2JMgeFa6
Cc: yawano@chromium.org
I think the desired behavior is to get the confirmation dialog on OOBE.
Google Chrome	69.0.3494.0 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

I just tried again and still can't get high contrast to turn on using ctrl + search + h. I am able to toggle it off and on using the Accessibility menu but not using the keyboard shortcut. 

Thanks for the very clear video and screenshot! 

Could it be platform specific? 
Hi Laura,
sorry for not being clear. The video/ screenshot I sent was including some changes that I made, and I wanted to make sure I had the correct OOBE screen as you, before proceeding further.

So if this is what's desired, I will continue with it!
Yes, that video shows exactly what is desired. Thanks! 
Labels: M69A11yTests
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e560fa7a50e529f4fed8adecd0e72bbb30b16e9

commit 6e560fa7a50e529f4fed8adecd0e72bbb30b16e9
Author: Sara Kato <sarakato@chromium.org>
Date: Tue Aug 07 01:42:22 2018

Ensure that dialog is shown on OOBE screen

Previous change (https://chromium-review.googlesource.com/c/chromium/src/+/1144581) allowed the confirmation dialog to be shown on sign on screen,
however on OOBE screen the dialog needs to be set to be on top of everything else.

Bug: 867478
Change-Id: Ie81e5ad3926c16860f87fb100eb4c0fe7bcba88b
Test: Manual
Reviewed-on: https://chromium-review.googlesource.com/1152329
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581088}
[modify] https://crrev.com/6e560fa7a50e529f4fed8adecd0e72bbb30b16e9/ash/accelerators/accelerator_confirmation_dialog.cc

Sign in to add a comment