Fake omnibox not removed when focused from bottom toolbar |
|||||||
Issue descriptionM70 What steps will reproduce the problem? (1) Open NTP (2) Scroll the NTP such as the fake omnibox is pinned to the top (3) Tap the search button on the bottom toolbar What is the expected result? The fake omnibox should be focused and replaced with the real omnibox What happens instead? The fake omnibox isn't removed, but the real omnibox is focus. It is possible to type but nothing appear on screen. p1 as it might be linked to issue 865408
,
Jul 25
,
Jul 25
Issue 867560 has been merged into this issue.
,
Jul 26
Issue 867691 has been merged into this issue.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96585bf6ff840727b7e1238b59ffb5a9f89840c6 commit 96585bf6ff840727b7e1238b59ffb5a9f89840c6 Author: Justin Cohen <justincohen@google.com> Date: Thu Jul 26 12:09:46 2018 [ios] Fix broken NTP when focusing the omnibox from the toolbar. Always call shiftTilesUp on both refresh and non-UI Refresh, but don't stomp on |collectionShiftingOffset| if the header is already pinned. Bug: 867458 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21f805eeca85406db5389c8b89db59fd097b4a10 Reviewed-on: https://chromium-review.googlesource.com/1150427 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578267} [modify] https://crrev.com/96585bf6ff840727b7e1238b59ffb5a9f89840c6/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/96585bf6ff840727b7e1238b59ffb5a9f89840c6/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/96585bf6ff840727b7e1238b59ffb5a9f89840c6/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
,
Jul 26
,
Jul 26
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e424c1615c1f97c7bc4db3c378b433435cbf0d11 commit e424c1615c1f97c7bc4db3c378b433435cbf0d11 Author: Justin Cohen <justincohen@google.com> Date: Fri Jul 27 17:44:38 2018 [ios] Fix broken NTP when focusing the omnibox from the toolbar. Always call shiftTilesUp on both refresh and non-UI Refresh, but don't stomp on |collectionShiftingOffset| if the header is already pinned. Bug: 867458 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21f805eeca85406db5389c8b89db59fd097b4a10 Reviewed-on: https://chromium-review.googlesource.com/1150427 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578267}(cherry picked from commit 96585bf6ff840727b7e1238b59ffb5a9f89840c6) Reviewed-on: https://chromium-review.googlesource.com/1153407 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#165} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/e424c1615c1f97c7bc4db3c378b433435cbf0d11/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/e424c1615c1f97c7bc4db3c378b433435cbf0d11/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/e424c1615c1f97c7bc4db3c378b433435cbf0d11/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
,
Jul 31
Verified on chrome canary version 70.0.3508.0 on iPhone 8 plus with iOS 11.4.1, 12 beta following steps mentioned in comment #0. Looks good.
,
Aug 1
Verified in: App Version: 69.0.3497.22 beta Devices: iPhone 7 Plus, iPhone 6 Plus iOS Version: 10.3.3, 11.4.1 Fake omnibox is focused when focusing the omnibox from toolbar |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by justincohen@chromium.org
, Jul 25