New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867455 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2

Blocking:
issue 867458



Sign in to add a comment

More refinement for NTP focus animations

Project Member Reported by justincohen@chromium.org, Jul 25

Issue description

Further refinement for conversations about omnibox focus issues should go here.
 
Cc: pinkerton@chromium.org
Blocking: 867458
Owner: gambard@chromium.org
gambard@ can you chat with mardini@ and martijnb@ to see if there are any tweaks we can make to this in M69, such as speeding up the animation, etc?

Post M69, we should give this more attention.
There was some discussion at the UX implementation review, though not enough to come to a decision. 

The main point was that the Fakebox to omnibox animation feels a little slow, though this may be constrained by the keyboard speed. When the text saying Search or type URL"  jumps to the left, it also looks a bit jarring since it jumps while the keyboard animates upward.

One possible solution that ainslie@ mentioned was to just remove the "Search or type URL" once the user taps on fakebox. This may be problematic, though, since that text prompt may help users understand the functionality of the omnibox.

Labels: MS-New-Tab Q2
Status: Started (was: Assigned)
Gauthier and Martijn spent some time on this and improved it a bit. Martijn will be sending videos to Alex to get feedback. Marking as Started since it's being actively worked on. 
Labels: zine-triaged
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01fca2bbada64293709007f31be4caeabe7273f2

commit 01fca2bbada64293709007f31be4caeabe7273f2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Aug 01 08:38:13 2018

NTP focus animation tweaks

Tweaks the animation when focusing the fakebox in NTP.

Bug:  867455 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I44a7c799e6269a1fdf6806b2cd54cdcdfc46336f
Reviewed-on: https://chromium-review.googlesource.com/1156697
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579730}
[modify] https://crrev.com/01fca2bbada64293709007f31be4caeabe7273f2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/01fca2bbada64293709007f31be4caeabe7273f2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/01fca2bbada64293709007f31be4caeabe7273f2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/01fca2bbada64293709007f31be4caeabe7273f2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/01fca2bbada64293709007f31be4caeabe7273f2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Labels: Merge-TBD
Cc: kariahda@chromium.org
Labels: -Merge-TBD Merge-Request-69
Status: Verified (was: Started)
Verified on Canary.
+kariahda@ for merge approval.

Labels: -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dc068d85274866fd005568dfdbd50fce3f5e8f8

commit 3dc068d85274866fd005568dfdbd50fce3f5e8f8
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 02 18:17:33 2018

NTP focus animation tweaks

Tweaks the animation when focusing the fakebox in NTP.

Bug:  867455 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I44a7c799e6269a1fdf6806b2cd54cdcdfc46336f
Reviewed-on: https://chromium-review.googlesource.com/1156697
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579730}(cherry picked from commit 01fca2bbada64293709007f31be4caeabe7273f2)
Reviewed-on: https://chromium-review.googlesource.com/1160504
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#343}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3dc068d85274866fd005568dfdbd50fce3f5e8f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/3dc068d85274866fd005568dfdbd50fce3f5e8f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/3dc068d85274866fd005568dfdbd50fce3f5e8f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/3dc068d85274866fd005568dfdbd50fce3f5e8f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/3dc068d85274866fd005568dfdbd50fce3f5e8f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Verified in 69.0.3497.25 Beta,  iPhone X iOS 11.4.1 beta 6, iPad Air iOS 11.4.

Search or type URL moves to the left once only after it located at the top of the screen.

https://drive.google.com/file/d/18615qSlZ4RvCjdndidPLoXv2W6dZA8gJ/view

Sign in to add a comment