New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867454 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Jul 30
Cc:
agrieve@chromium.org
jbudorick@chromium.org
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix fetch_all.py to check CIPD for same tags before printing commands

Project Member Reported by wnwen@chromium.org, Jul 25 
CIPD allows the same tag to be used for multiple instances of the same package. DEPS pins to a particular package and tag, so if it resolves to multiple instances it can crash gclient and prevent syncing.

Fix this so that fetch_all.py checks CIPD for tag collisions before displaying CIPD commands to create and upload new instances.

See  issue 866912  for context
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/376425bd035f55749f08f0d454e64b38aaa1846c

commit 376425bd035f55749f08f0d454e64b38aaa1846c
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jul 30 19:43:11 2018

Android: Fix fetch_all.py's CIPD commands

Print CIPD commands that avoid creating new ones if existing CIPD
packages are found with the same tags, display those with
`cipd describe` instead.

Bug:  867454 
Change-Id: I9cccdcf55d5ddb02a98f4dd8d530d9240618b817
Reviewed-on: https://chromium-review.googlesource.com/1155480
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579126}
[modify] https://crrev.com/376425bd035f55749f08f0d454e64b38aaa1846c/tools/android/roll/android_deps/fetch_all.py

Comment 2 by wnwen@chromium.org, Jul 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment